mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-08-21 11:21:39 +00:00
58794ae118
Expand the Option argument paradigm to:
* Remove the requirement to always pass a 'type' parameter. Type inferencing is the easier, and increasingly common way to declare a variable, so this prevents a whole lot of `nullptr` smell which negatively impacts readability.
* Accept attributes directly as arguments, removing the `utils::Vector{ ... }` smell.
Rename `ProgramBuilder::VarOptionals` to `VarOptions`, and add equivalent `LetOptions`, `ConstOptions` and `OverrideOptions`.
Clean up all the calls to `Var()`, `Let()`, `Const()` and `Override()`:
* Use the `Group()` and `Binding()` helpers where possible
* Removing `nullptr` type arguments
* Replace attribute vectors with the list of attributes.
* Remove already-defaulted `ast::StorageClass::kNone` arguments.
* Remove already-defaulted `ast::Access::kUndefined` arguments.
Finally, remove the `GroupAndBinding()` helper, which only existed because you needed to pass attributes as a vector.
Change-Id: I8890e4eb0ffac9f9df2207b28a6f02a163e34d96
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/99580
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Commit-Queue: Ben Clayton <bclayton@chromium.org>
97 lines
3.0 KiB
C++
97 lines
3.0 KiB
C++
// Copyright 2022 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include <utility>
|
|
|
|
#include "gtest/gtest-spi.h"
|
|
#include "src/tint/debug.h"
|
|
#include "src/tint/program_builder.h"
|
|
#include "src/tint/transform/test_helper.h"
|
|
#include "src/tint/transform/utils/get_insertion_point.h"
|
|
|
|
using namespace tint::number_suffixes; // NOLINT
|
|
|
|
namespace tint::transform {
|
|
namespace {
|
|
|
|
using GetInsertionPointTest = ::testing::Test;
|
|
|
|
TEST_F(GetInsertionPointTest, Block) {
|
|
// fn f() {
|
|
// var a = 1i;
|
|
// }
|
|
ProgramBuilder b;
|
|
auto* expr = b.Expr(1_i);
|
|
auto* var = b.Decl(b.Var("a", expr));
|
|
auto* block = b.Block(var);
|
|
b.Func("f", tint::utils::Empty, b.ty.void_(), tint::utils::Vector{block});
|
|
|
|
Program original(std::move(b));
|
|
ProgramBuilder cloned_b;
|
|
CloneContext ctx(&cloned_b, &original);
|
|
|
|
// Can insert in block containing the variable, above or below the input
|
|
// statement.
|
|
auto ip = utils::GetInsertionPoint(ctx, var);
|
|
ASSERT_EQ(ip.first->Declaration(), block);
|
|
ASSERT_EQ(ip.second, var);
|
|
}
|
|
|
|
TEST_F(GetInsertionPointTest, ForLoopInit) {
|
|
// fn f() {
|
|
// for(var a = 1i; true; ) {
|
|
// }
|
|
// }
|
|
ProgramBuilder b;
|
|
auto* expr = b.Expr(1_i);
|
|
auto* var = b.Decl(b.Var("a", expr));
|
|
auto* fl = b.For(var, b.Expr(true), nullptr, b.Block());
|
|
auto* func_block = b.Block(fl);
|
|
b.Func("f", tint::utils::Empty, b.ty.void_(), tint::utils::Vector{func_block});
|
|
|
|
Program original(std::move(b));
|
|
ProgramBuilder cloned_b;
|
|
CloneContext ctx(&cloned_b, &original);
|
|
|
|
// Can insert in block containing for-loop above the for-loop itself.
|
|
auto ip = utils::GetInsertionPoint(ctx, var);
|
|
ASSERT_EQ(ip.first->Declaration(), func_block);
|
|
ASSERT_EQ(ip.second, fl);
|
|
}
|
|
|
|
TEST_F(GetInsertionPointTest, ForLoopCont_Invalid) {
|
|
// fn f() {
|
|
// for(; true; var a = 1i) {
|
|
// }
|
|
// }
|
|
ProgramBuilder b;
|
|
auto* expr = b.Expr(1_i);
|
|
auto* var = b.Decl(b.Var("a", expr));
|
|
auto* s = b.For({}, b.Expr(true), var, b.Block());
|
|
b.Func("f", tint::utils::Empty, b.ty.void_(), tint::utils::Vector{s});
|
|
|
|
Program original(std::move(b));
|
|
ProgramBuilder cloned_b;
|
|
CloneContext ctx(&cloned_b, &original);
|
|
|
|
// Can't insert before/after for loop continue statement (would ned to be
|
|
// converted to loop).
|
|
auto ip = utils::GetInsertionPoint(ctx, var);
|
|
ASSERT_EQ(ip.first, nullptr);
|
|
ASSERT_EQ(ip.second, nullptr);
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace tint::transform
|