mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-07-14 00:56:05 +00:00
5ad5557667
The wire's device is externally owned so reference/release were no-ops. To unify the code paths, remove the special casing and instead take an extra ref on the device the wire server is created with. This is functionally equivalent and will allow both the current wire code, and the incoming change to allow multiple device/adapter creation to both work. This CL also makes it possible for the client to destroy the device before child objects. A follow-up CL will mitigate this on the server side. Bug: dawn:384 Change-Id: Ic5427074469012dccf8689ec95a848e6ba2c1fc2 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/37001 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
98 lines
4.2 KiB
C++
98 lines
4.2 KiB
C++
//* Copyright 2019 The Dawn Authors
|
|
//*
|
|
//* Licensed under the Apache License, Version 2.0 (the "License");
|
|
//* you may not use this file except in compliance with the License.
|
|
//* You may obtain a copy of the License at
|
|
//*
|
|
//* http://www.apache.org/licenses/LICENSE-2.0
|
|
//*
|
|
//* Unless required by applicable law or agreed to in writing, software
|
|
//* distributed under the License is distributed on an "AS IS" BASIS,
|
|
//* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
//* See the License for the specific language governing permissions and
|
|
//* limitations under the License.
|
|
|
|
#include "common/Assert.h"
|
|
#include "dawn_wire/server/Server.h"
|
|
|
|
namespace dawn_wire { namespace server {
|
|
//* Implementation of the command doers
|
|
{% for command in cmd_records["command"] %}
|
|
{% set type = command.derived_object %}
|
|
{% set method = command.derived_method %}
|
|
{% set is_method = method is not none %}
|
|
|
|
{% set Suffix = command.name.CamelCase() %}
|
|
{% if Suffix not in client_side_commands %}
|
|
{% if is_method and Suffix not in server_handwritten_commands %}
|
|
bool Server::Do{{Suffix}}(
|
|
{%- for member in command.members -%}
|
|
{%- if member.is_return_value -%}
|
|
{%- if member.handle_type -%}
|
|
{{as_cType(member.handle_type.name)}}* {{as_varName(member.name)}}
|
|
{%- else -%}
|
|
{{as_cType(member.type.name)}}* {{as_varName(member.name)}}
|
|
{%- endif -%}
|
|
{%- else -%}
|
|
{{as_annotated_cType(member)}}
|
|
{%- endif -%}
|
|
{%- if not loop.last -%}, {% endif %}
|
|
{%- endfor -%}
|
|
) {
|
|
{% set ret = command.members|selectattr("is_return_value")|list %}
|
|
//* If there is a return value, assign it.
|
|
{% if ret|length == 1 %}
|
|
*{{as_varName(ret[0].name)}} =
|
|
{% else %}
|
|
//* Only one member should be a return value.
|
|
{{ assert(ret|length == 0) }}
|
|
{% endif %}
|
|
mProcs.{{as_varName(type.name, method.name)}}(
|
|
{%- for member in command.members if not member.is_return_value -%}
|
|
{{as_varName(member.name)}}
|
|
{%- if not loop.last -%}, {% endif %}
|
|
{%- endfor -%}
|
|
);
|
|
{% if ret|length == 1 %}
|
|
//* WebGPU error handling guarantees that no null object can be returned by
|
|
//* object creation functions.
|
|
ASSERT(*{{as_varName(ret[0].name)}} != nullptr);
|
|
{% endif %}
|
|
return true;
|
|
}
|
|
{% endif %}
|
|
{% endif %}
|
|
{% endfor %}
|
|
|
|
bool Server::DoDestroyObject(ObjectType objectType, ObjectId objectId) {
|
|
//* ID 0 are reserved for nullptr and cannot be destroyed.
|
|
if (objectId == 0) {
|
|
return false;
|
|
}
|
|
|
|
switch(objectType) {
|
|
{% for type in by_category["object"] %}
|
|
case ObjectType::{{type.name.CamelCase()}}: {
|
|
auto* data = {{type.name.CamelCase()}}Objects().Get(objectId);
|
|
if (data == nullptr) {
|
|
return false;
|
|
}
|
|
{% if type.name.CamelCase() in server_reverse_lookup_objects %}
|
|
{{type.name.CamelCase()}}ObjectIdTable().Remove(data->handle);
|
|
{% endif %}
|
|
if (data->handle != nullptr) {
|
|
mProcs.{{as_varName(type.name, Name("release"))}}(data->handle);
|
|
}
|
|
{{type.name.CamelCase()}}Objects().Free(objectId);
|
|
return true;
|
|
}
|
|
{% endfor %}
|
|
default:
|
|
return false;
|
|
}
|
|
|
|
return true;
|
|
}
|
|
|
|
}} // namespace dawn_wire::server
|