mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-08-12 06:59:21 +00:00
627732c408
The reason being that some tests called parse() twice, which will silently destruct the first parser. Once the `Module` owns the AST nodes, the second call will end up deleting all the AST nodes. Tests would then perform use-after-free for the AST nodes belonging to the first parser / module. There's no reason why the unique_ptr can't be returned, which is cleaner overall. Bug: tint:335 Change-Id: I7ff2e9777a7ebeb76702f806294fe4c2c49bd7c9 Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/33241 Auto-Submit: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org> Commit-Queue: dan sinclair <dsinclair@chromium.org>
48 lines
1.4 KiB
C++
48 lines
1.4 KiB
C++
// Copyright 2020 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "gtest/gtest.h"
|
|
#include "src/reader/wgsl/parser_impl.h"
|
|
#include "src/reader/wgsl/parser_impl_test_helper.h"
|
|
|
|
namespace tint {
|
|
namespace reader {
|
|
namespace wgsl {
|
|
namespace {
|
|
|
|
TEST_F(ParserImplTest, ContinuingStmt) {
|
|
auto p = parser("continuing { discard; }");
|
|
auto e = p->continuing_stmt();
|
|
EXPECT_TRUE(e.matched);
|
|
EXPECT_FALSE(e.errored);
|
|
EXPECT_FALSE(p->has_error()) << p->error();
|
|
ASSERT_EQ(e->size(), 1u);
|
|
ASSERT_TRUE(e->get(0)->IsDiscard());
|
|
}
|
|
|
|
TEST_F(ParserImplTest, ContinuingStmt_InvalidBody) {
|
|
auto p = parser("continuing { discard }");
|
|
auto e = p->continuing_stmt();
|
|
EXPECT_FALSE(e.matched);
|
|
EXPECT_TRUE(e.errored);
|
|
EXPECT_EQ(e.value, nullptr);
|
|
EXPECT_TRUE(p->has_error());
|
|
EXPECT_EQ(p->error(), "1:22: expected ';' for discard statement");
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace wgsl
|
|
} // namespace reader
|
|
} // namespace tint
|