encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
dawn-cmake/test/var/uses
History
Corentin Wallez e33b0baa08 Revert "MSL writer: make signed int overflow defined behaviour" 
This reverts commit e5dbe24e94.

Reason for revert: Makes the Tint-Dawn roll fails because of
MSL compilation errors on as_type<uint>(-2147483648):
as_type cast from 'long' to 'uint' (aka 'unsigned int') is not allowed
   
as_type<uint>(-2147483647) compiles fine, so this is most
likely because the MSL compiler types the literal as a long
(since without the - it is larger than the max int32).

Original change's description:
> MSL writer: make signed int overflow defined behaviour
>
> Bug: tint:124
> Change-Id: Icf545b633d6390ceb7f639e80111390005e311a1
> Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/60100
> Kokoro: Kokoro <noreply+kokoro@google.com>
> Commit-Queue: Antonio Maiorano <amaiorano@google.com>
> Reviewed-by: David Neto <dneto@google.com>

TBR=dneto@google.com,bclayton@google.com,jrprice@google.com,amaiorano@google.com,noreply+kokoro@google.com,tint-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I3e3384a9185013bb141a1b7b9b22bad8571bbc50
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: tint:124
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/60345
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Ben Clayton <bclayton@google.com>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 		2021-07-30 08:22:58 +00:00
..
private.wgsl test: move test/var files to test/var/uses 2021-06-30 15:58:50 +00:00
private.wgsl.expected.hlsl test: move test/var files to test/var/uses 2021-06-30 15:58:50 +00:00
private.wgsl.expected.msl Revert "MSL writer: make signed int overflow defined behaviour" 2021-07-30 08:22:58 +00:00
private.wgsl.expected.spvasm test: move test/var files to test/var/uses 2021-06-30 15:58:50 +00:00
private.wgsl.expected.wgsl test: move test/var files to test/var/uses 2021-06-30 15:58:50 +00:00
workgroup.wgsl test: move test/var files to test/var/uses 2021-06-30 15:58:50 +00:00
workgroup.wgsl.expected.hlsl test: move test/var files to test/var/uses 2021-06-30 15:58:50 +00:00
workgroup.wgsl.expected.msl Revert "MSL writer: make signed int overflow defined behaviour" 2021-07-30 08:22:58 +00:00
workgroup.wgsl.expected.spvasm test: move test/var files to test/var/uses 2021-06-30 15:58:50 +00:00
workgroup.wgsl.expected.wgsl test: move test/var files to test/var/uses 2021-06-30 15:58:50 +00:00