mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-10-19 00:05:51 +00:00
de078bad8d
When InstanceBase::ProcessEvents() iterates through list of devices, one device might be being destructed on another thread. Even if we try to increase ref count of that device inside the ProcessEvents(), the device might be in the middle of destructor call on another thread, increasing the ref count is invalid in this case. This CL attempts to fix this issue by removing the device's pointer from InstanceBase earlier: when DeviceBase::WillDropLastExternalRef() is called. After this point, any callback registered to this device will be forwarded to InstanceBase's callback queue instead. Bug: dawn:752 Change-Id: I8ae86575e34f753e52a76f5fc774bbb5366a1b85 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/124281 Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Quyen Le <lehoangquyen@chromium.org> Reviewed-by: Loko Kung <lokokung@google.com>