mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-05-13 10:51:35 +00:00
Use templated functions to make calling SetDebugLabel safer, with less opportunities to screw up the casting and automatic lookup of the VkObjectType for most handles. Change-Id: I0938ad6fd7d5fe81569bdee5bc7ec7e396db7bcd Bug: dawn:1323 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86580 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Brandon Jones <bajones@google.com>
165 lines
7.2 KiB
C++
165 lines
7.2 KiB
C++
// Copyright 2018 The Dawn Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "dawn/native/vulkan/BindGroupVk.h"
|
|
|
|
#include "dawn/common/BitSetIterator.h"
|
|
#include "dawn/common/ityp_stack_vec.h"
|
|
#include "dawn/native/ExternalTexture.h"
|
|
#include "dawn/native/vulkan/BindGroupLayoutVk.h"
|
|
#include "dawn/native/vulkan/BufferVk.h"
|
|
#include "dawn/native/vulkan/DeviceVk.h"
|
|
#include "dawn/native/vulkan/FencedDeleter.h"
|
|
#include "dawn/native/vulkan/SamplerVk.h"
|
|
#include "dawn/native/vulkan/TextureVk.h"
|
|
#include "dawn/native/vulkan/UtilsVulkan.h"
|
|
#include "dawn/native/vulkan/VulkanError.h"
|
|
|
|
namespace dawn::native::vulkan {
|
|
|
|
// static
|
|
ResultOrError<Ref<BindGroup>> BindGroup::Create(Device* device,
|
|
const BindGroupDescriptor* descriptor) {
|
|
return ToBackend(descriptor->layout)->AllocateBindGroup(device, descriptor);
|
|
}
|
|
|
|
BindGroup::BindGroup(Device* device,
|
|
const BindGroupDescriptor* descriptor,
|
|
DescriptorSetAllocation descriptorSetAllocation)
|
|
: BindGroupBase(this, device, descriptor),
|
|
mDescriptorSetAllocation(descriptorSetAllocation) {
|
|
// Now do a write of a single descriptor set with all possible chained data allocated on the
|
|
// stack.
|
|
const uint32_t bindingCount = static_cast<uint32_t>((GetLayout()->GetBindingCount()));
|
|
ityp::stack_vec<uint32_t, VkWriteDescriptorSet, kMaxOptimalBindingsPerGroup> writes(
|
|
bindingCount);
|
|
ityp::stack_vec<uint32_t, VkDescriptorBufferInfo, kMaxOptimalBindingsPerGroup>
|
|
writeBufferInfo(bindingCount);
|
|
ityp::stack_vec<uint32_t, VkDescriptorImageInfo, kMaxOptimalBindingsPerGroup>
|
|
writeImageInfo(bindingCount);
|
|
|
|
uint32_t numWrites = 0;
|
|
for (const auto [_, bindingIndex] : GetLayout()->GetBindingMap()) {
|
|
const BindingInfo& bindingInfo = GetLayout()->GetBindingInfo(bindingIndex);
|
|
|
|
auto& write = writes[numWrites];
|
|
write.sType = VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET;
|
|
write.pNext = nullptr;
|
|
write.dstSet = GetHandle();
|
|
write.dstBinding = static_cast<uint32_t>(bindingIndex);
|
|
write.dstArrayElement = 0;
|
|
write.descriptorCount = 1;
|
|
write.descriptorType = VulkanDescriptorType(bindingInfo);
|
|
|
|
switch (bindingInfo.bindingType) {
|
|
case BindingInfoType::Buffer: {
|
|
BufferBinding binding = GetBindingAsBufferBinding(bindingIndex);
|
|
|
|
VkBuffer handle = ToBackend(binding.buffer)->GetHandle();
|
|
if (handle == VK_NULL_HANDLE) {
|
|
// The Buffer was destroyed. Skip this descriptor write since it would be
|
|
// a Vulkan Validation Layers error. This bind group won't be used as it
|
|
// is an error to submit a command buffer that references destroyed
|
|
// resources.
|
|
continue;
|
|
}
|
|
writeBufferInfo[numWrites].buffer = handle;
|
|
writeBufferInfo[numWrites].offset = binding.offset;
|
|
writeBufferInfo[numWrites].range = binding.size;
|
|
write.pBufferInfo = &writeBufferInfo[numWrites];
|
|
break;
|
|
}
|
|
|
|
case BindingInfoType::Sampler: {
|
|
Sampler* sampler = ToBackend(GetBindingAsSampler(bindingIndex));
|
|
writeImageInfo[numWrites].sampler = sampler->GetHandle();
|
|
write.pImageInfo = &writeImageInfo[numWrites];
|
|
break;
|
|
}
|
|
|
|
case BindingInfoType::Texture: {
|
|
TextureView* view = ToBackend(GetBindingAsTextureView(bindingIndex));
|
|
|
|
VkImageView handle = view->GetHandle();
|
|
if (handle == VK_NULL_HANDLE) {
|
|
// The Texture was destroyed before the TextureView was created.
|
|
// Skip this descriptor write since it would be
|
|
// a Vulkan Validation Layers error. This bind group won't be used as it
|
|
// is an error to submit a command buffer that references destroyed
|
|
// resources.
|
|
continue;
|
|
}
|
|
writeImageInfo[numWrites].imageView = handle;
|
|
|
|
// The layout may be GENERAL here because of interactions between the Sampled
|
|
// and ReadOnlyStorage usages. See the logic in VulkanImageLayout.
|
|
writeImageInfo[numWrites].imageLayout = VulkanImageLayout(
|
|
ToBackend(view->GetTexture()), wgpu::TextureUsage::TextureBinding);
|
|
|
|
write.pImageInfo = &writeImageInfo[numWrites];
|
|
break;
|
|
}
|
|
|
|
case BindingInfoType::StorageTexture: {
|
|
TextureView* view = ToBackend(GetBindingAsTextureView(bindingIndex));
|
|
|
|
VkImageView handle = view->GetHandle();
|
|
if (handle == VK_NULL_HANDLE) {
|
|
// The Texture was destroyed before the TextureView was created.
|
|
// Skip this descriptor write since it would be
|
|
// a Vulkan Validation Layers error. This bind group won't be used as it
|
|
// is an error to submit a command buffer that references destroyed
|
|
// resources.
|
|
continue;
|
|
}
|
|
writeImageInfo[numWrites].imageView = handle;
|
|
writeImageInfo[numWrites].imageLayout = VK_IMAGE_LAYOUT_GENERAL;
|
|
|
|
write.pImageInfo = &writeImageInfo[numWrites];
|
|
break;
|
|
}
|
|
|
|
case BindingInfoType::ExternalTexture:
|
|
UNREACHABLE();
|
|
break;
|
|
}
|
|
|
|
numWrites++;
|
|
}
|
|
|
|
// TODO(crbug.com/dawn/855): Batch these updates
|
|
device->fn.UpdateDescriptorSets(device->GetVkDevice(), numWrites, writes.data(), 0,
|
|
nullptr);
|
|
|
|
SetLabelImpl();
|
|
}
|
|
|
|
BindGroup::~BindGroup() = default;
|
|
|
|
void BindGroup::DestroyImpl() {
|
|
BindGroupBase::DestroyImpl();
|
|
ToBackend(GetLayout())->DeallocateBindGroup(this, &mDescriptorSetAllocation);
|
|
}
|
|
|
|
VkDescriptorSet BindGroup::GetHandle() const {
|
|
return mDescriptorSetAllocation.set;
|
|
}
|
|
|
|
void BindGroup::SetLabelImpl() {
|
|
SetDebugName(ToBackend(GetDevice()), mDescriptorSetAllocation.set, "Dawn_BindGroup",
|
|
GetLabel());
|
|
}
|
|
|
|
} // namespace dawn::native::vulkan
|