mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-08-15 08:29:24 +00:00
545c9742d5
In C++ argument evaluation order is undefined. MSVC and Clang evaluate these in different orders, leading to hilarity when writing tests that expect a deterministic ordering. Pull out all the argument expressions to create() in the clone functions so a cloned program is deterministic in its ordering between compilers. Change-Id: I8e2de31398960c480ce7ee1dfaac4f67652d2dbc Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/41544 Commit-Queue: Ben Clayton <bclayton@google.com> Reviewed-by: dan sinclair <dsinclair@chromium.org> Auto-Submit: Ben Clayton <bclayton@google.com>
73 lines
2.0 KiB
C++
73 lines
2.0 KiB
C++
// Copyright 2020 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "src/ast/return_statement.h"
|
|
|
|
#include "src/clone_context.h"
|
|
#include "src/program_builder.h"
|
|
|
|
TINT_INSTANTIATE_CLASS_ID(tint::ast::ReturnStatement);
|
|
|
|
namespace tint {
|
|
namespace ast {
|
|
|
|
ReturnStatement::ReturnStatement(const Source& source)
|
|
: Base(source), value_(nullptr) {}
|
|
|
|
ReturnStatement::ReturnStatement(const Source& source, Expression* value)
|
|
: Base(source), value_(value) {}
|
|
|
|
ReturnStatement::ReturnStatement(ReturnStatement&&) = default;
|
|
|
|
ReturnStatement::~ReturnStatement() = default;
|
|
|
|
ReturnStatement* ReturnStatement::Clone(CloneContext* ctx) const {
|
|
// Clone arguments outside of create() call to have deterministic ordering
|
|
auto src = ctx->Clone(source());
|
|
auto* ret = ctx->Clone(value());
|
|
return ctx->dst->create<ReturnStatement>(src, ret);
|
|
}
|
|
|
|
bool ReturnStatement::IsValid() const {
|
|
if (value_ != nullptr) {
|
|
return value_->IsValid();
|
|
}
|
|
return true;
|
|
}
|
|
|
|
void ReturnStatement::to_str(const semantic::Info& sem,
|
|
std::ostream& out,
|
|
size_t indent) const {
|
|
make_indent(out, indent);
|
|
out << "Return{";
|
|
|
|
if (value_) {
|
|
out << std::endl;
|
|
|
|
make_indent(out, indent + 2);
|
|
out << "{" << std::endl;
|
|
|
|
value_->to_str(sem, out, indent + 4);
|
|
|
|
make_indent(out, indent + 2);
|
|
out << "}" << std::endl;
|
|
|
|
make_indent(out, indent);
|
|
}
|
|
out << "}" << std::endl;
|
|
}
|
|
|
|
} // namespace ast
|
|
} // namespace tint
|