encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
dawn-cmake/test/builtins/gen/textureLoad
History
Stephen White d9b32c3178 GLSL: fix textureLoad() and textureStore(), depth textures, and more. 
The CombineSamplers transform was incorrectly flagging StorageTexture
(which in GLSL ends up as image2D) as needing to be combined with a
sampler, or at least renamed. This is incorrect: StorageTexture never
has an associated sampler, so don't try to pair it up and just output
it as image* in GLSL.

In GLSL, textureLoad (aka texelFetch) of depth textures is not allowed.
The fix is to bind the depth texture as the corresponding f32 texture
instead (e.g., texture_depth_2d -> texture_2d<f32>,
texture_depth_cube -> texture_cube<f32>, etc). This requires changing
both the uniform globals and function parameter types. We're now going
to receive a vec4 instead of a float from texelFetch, so add a ".x"
member accessor to retrieve the first component. (Note that we don't
do this inside a CallStatement since this gives the CloneContext
indigestion, and CallStatement is going to ignore the result of the
call anyway.)

We were failing to find the dummy samplers that Dawn creates for the
calls that actually do require a dummy sampler, since the old Inspector
implementation of GetSamplerTextureUses() does not find them. The fix
is to implement a new Inspector call to return the texture/sampler
pairs the Resolver found during resolution. This will include the
dummy sampler as a null variable pointer.

In order to identify the placeholder sampler, we pass in a BindingPair
to represent it. When we discover a null sampler in the variable pair,
we return the passed-in placeholder binding point to the caller (Dawn).
(Dawn will use a group of kMaxBindGroups, to ensure that it never
collides with an existing sampler.)

Bug: tint:1298
Change-Id: I82e142c2b4318608c27a9fa9521c27f15a6214cd
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/78820
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Stephen White <senorblanco@chromium.org>
 		2022-02-03 22:39:13 +00:00
..
1b8588.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
1b8588.wgsl.expected.glsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
1b8588.wgsl.expected.hlsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
1b8588.wgsl.expected.msl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
1b8588.wgsl.expected.spvasm Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
1b8588.wgsl.expected.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
1f2016.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
1f2016.wgsl.expected.glsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
1f2016.wgsl.expected.hlsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
1f2016.wgsl.expected.msl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
1f2016.wgsl.expected.spvasm Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
1f2016.wgsl.expected.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
4fd803.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
4fd803.wgsl.expected.glsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
4fd803.wgsl.expected.hlsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
4fd803.wgsl.expected.msl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
4fd803.wgsl.expected.spvasm Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
4fd803.wgsl.expected.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
5a2f9d.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
5a2f9d.wgsl.expected.glsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
5a2f9d.wgsl.expected.hlsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
5a2f9d.wgsl.expected.msl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
5a2f9d.wgsl.expected.spvasm Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
5a2f9d.wgsl.expected.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
7c90e5.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
7c90e5.wgsl.expected.glsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
7c90e5.wgsl.expected.hlsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
7c90e5.wgsl.expected.msl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
7c90e5.wgsl.expected.spvasm Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
7c90e5.wgsl.expected.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
8acf41.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
8acf41.wgsl.expected.glsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
8acf41.wgsl.expected.hlsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
8acf41.wgsl.expected.msl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
8acf41.wgsl.expected.spvasm Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
8acf41.wgsl.expected.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
9b2667.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
9b2667.wgsl.expected.glsl GLSL: fix textureLoad() and textureStore(), depth textures, and more. 2022-02-03 22:39:13 +00:00
9b2667.wgsl.expected.hlsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
9b2667.wgsl.expected.msl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
9b2667.wgsl.expected.spvasm Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
9b2667.wgsl.expected.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
19cf87.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
19cf87.wgsl.expected.glsl GLSL: fix textureLoad() and textureStore(), depth textures, and more. 2022-02-03 22:39:13 +00:00
19cf87.wgsl.expected.hlsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
19cf87.wgsl.expected.msl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
19cf87.wgsl.expected.spvasm Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
19cf87.wgsl.expected.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
79e697.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
79e697.wgsl.expected.glsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
79e697.wgsl.expected.hlsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
79e697.wgsl.expected.msl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
79e697.wgsl.expected.spvasm Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
79e697.wgsl.expected.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
81c381.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
81c381.wgsl.expected.glsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
81c381.wgsl.expected.hlsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
81c381.wgsl.expected.msl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
81c381.wgsl.expected.spvasm Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
81c381.wgsl.expected.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
87be85.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
87be85.wgsl.expected.glsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
87be85.wgsl.expected.hlsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
87be85.wgsl.expected.msl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
87be85.wgsl.expected.spvasm Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
87be85.wgsl.expected.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
6154d4.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
6154d4.wgsl.expected.glsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
6154d4.wgsl.expected.hlsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
6154d4.wgsl.expected.msl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
6154d4.wgsl.expected.spvasm Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
6154d4.wgsl.expected.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
6273b1.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
6273b1.wgsl.expected.glsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
6273b1.wgsl.expected.hlsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
6273b1.wgsl.expected.msl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
6273b1.wgsl.expected.spvasm Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
6273b1.wgsl.expected.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
484344.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
484344.wgsl.expected.glsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
484344.wgsl.expected.hlsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
484344.wgsl.expected.msl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
484344.wgsl.expected.spvasm Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
484344.wgsl.expected.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
a9a9f5.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
a9a9f5.wgsl.expected.glsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
a9a9f5.wgsl.expected.hlsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
a9a9f5.wgsl.expected.msl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
a9a9f5.wgsl.expected.spvasm Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
a9a9f5.wgsl.expected.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
a583c9.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
a583c9.wgsl.expected.glsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
a583c9.wgsl.expected.hlsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
a583c9.wgsl.expected.msl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
a583c9.wgsl.expected.spvasm Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
a583c9.wgsl.expected.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
c2a480.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
c2a480.wgsl.expected.glsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
c2a480.wgsl.expected.hlsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
c2a480.wgsl.expected.msl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
c2a480.wgsl.expected.spvasm Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
c2a480.wgsl.expected.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
c378ee.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
c378ee.wgsl.expected.glsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
c378ee.wgsl.expected.hlsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
c378ee.wgsl.expected.msl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
c378ee.wgsl.expected.spvasm Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
c378ee.wgsl.expected.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
e3d2cc.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
e3d2cc.wgsl.expected.glsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
e3d2cc.wgsl.expected.hlsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
e3d2cc.wgsl.expected.msl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
e3d2cc.wgsl.expected.spvasm Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00
e3d2cc.wgsl.expected.wgsl Rename 'intrinsic' to 'builtin' 2022-02-02 23:07:11 +00:00