mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-06-01 12:11:34 +00:00
455f573d09
This reverts commit 63cea3f8c03a748c261b1f8e371735994c2e2552. ...except it skips adding the the constructor/destructor/copy definitions for dawn::native::Format. Adding them triggers "constexpr variable cannot have non-literal type" (or "declaration requires a global constructor" if it's not marked constexpr), unless they're explicitly marked as =default in the header - which just triggers a different chromium-style warning, so there's no point. A better solution to the chromium-style warning on Format may be to just make the class physically smaller: https://www.chromium.org/developers/coding-style/chromium-style-checker-errors/#constructordestructor-errors Bug: dawn:1405 Change-Id: Ied6e9d0abff6bf1330131a40c6583bab18888b67 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/90303 Reviewed-by: Dan Sinclair <dsinclair@chromium.org> Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Kai Ninomiya <kainino@chromium.org>