mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-08-24 12:42:11 +00:00
8d98977a30
Black-box the BuilderImpl by putting the BuilderImpl into the from_program.cc file. Why: * It means there's only a single definition of all the methods that need to be maintained, instead of pointlessly splitting code between two files (.cc / .h). * It removes all the implementation details from the header. * It removes a whole bunch of transitive includes, slowing compiles. * It prevents the temptation for future #includes to private-implementation details. * It reduces the amount of symbols declared outside of anonymous namespaces, reducing symbol polution and the amount of work on the linker. Bug: tint:1718 Change-Id: I82838089f784ab003dae4ef06545bba1ca2401cc Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/132321 Commit-Queue: Ben Clayton <bclayton@google.com> Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Dan Sinclair <dsinclair@chromium.org>
34 lines
974 B
C++
34 lines
974 B
C++
// Copyright 2023 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "src/tint/ir/builder.h"
|
|
#include "src/tint/ir/instruction.h"
|
|
#include "src/tint/ir/test_helper.h"
|
|
|
|
namespace tint::ir {
|
|
namespace {
|
|
|
|
using IR_InstructionTest = TestHelper;
|
|
|
|
TEST_F(IR_InstructionTest, Discard) {
|
|
Module mod;
|
|
Builder b{mod};
|
|
|
|
const auto* inst = b.Discard();
|
|
ASSERT_TRUE(inst->Is<ir::Discard>());
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace tint::ir
|