mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-07-25 06:25:42 +00:00
960918b1b6
This CL fix an issue related to tiering the maxBufferSize and maxStorageBufferBindingSize limits. In detail, this CL: 1. Fix the maxStorageBufferBindingSize tiers to [128MB, 1GB, 2GB-4, 4GB-4] instead of the original last two 2GB-1 and 4GB-1, holding the guarantee that maxStorageBufferBindingSize is a multiple of 4 bytes. 2. Add a maxBufferSize tier 4GB, ensuring the guarantee that maxStorageBufferBindingSize must be no larger than maxBufferSize in case of it tiered to 4GB-4. Previously the largest maxBufferSize tier is 2GB, making this guarantee broken after tiering. 3. Move the adapter limits normalization logics in adapter initializing to Limits.cpp to allow unittest. Related unittests implemented. 4. Normalize tiered limits to ensure that tiered maxStorageBufferBindingSize and maxUniformBufferBindingSize are no larger than tiered maxBufferSize. Related unittests implemented. Issue: dawn:1780 Change-Id: I4821f196fa89c7f18ebbf8e5e45df1c3268db895 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/130120 Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Zhaoming Jiang <zhaoming.jiang@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Austin Eng <enga@chromium.org>
66 lines
2.4 KiB
C++
66 lines
2.4 KiB
C++
// Copyright 2021 The Dawn Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#ifndef SRC_DAWN_NATIVE_LIMITS_H_
|
|
#define SRC_DAWN_NATIVE_LIMITS_H_
|
|
|
|
#include "dawn/native/Error.h"
|
|
#include "dawn/native/VisitableMembers.h"
|
|
#include "dawn/native/dawn_platform.h"
|
|
|
|
namespace dawn::native {
|
|
|
|
struct CombinedLimits {
|
|
Limits v1;
|
|
};
|
|
|
|
// Populate |limits| with the default limits.
|
|
void GetDefaultLimits(Limits* limits);
|
|
|
|
// Returns a copy of |limits| where all undefined values are replaced
|
|
// with their defaults. Also clamps to the defaults if the provided limits
|
|
// are worse.
|
|
Limits ReifyDefaultLimits(const Limits& limits);
|
|
|
|
// Validate that |requiredLimits| are no better than |supportedLimits|.
|
|
MaybeError ValidateLimits(const Limits& supportedLimits, const Limits& requiredLimits);
|
|
|
|
// Returns a copy of |limits| where limit tiers are applied.
|
|
Limits ApplyLimitTiers(Limits limits);
|
|
|
|
// If there are new limit member needed at shader compilation time
|
|
// Simply append a new X(type, name) here.
|
|
#define LIMITS_FOR_COMPILATION_REQUEST_MEMBERS(X) \
|
|
X(uint32_t, maxComputeWorkgroupSizeX) \
|
|
X(uint32_t, maxComputeWorkgroupSizeY) \
|
|
X(uint32_t, maxComputeWorkgroupSizeZ) \
|
|
X(uint32_t, maxComputeInvocationsPerWorkgroup) \
|
|
X(uint32_t, maxComputeWorkgroupStorageSize)
|
|
|
|
struct LimitsForCompilationRequest {
|
|
static LimitsForCompilationRequest Create(const Limits& limits);
|
|
DAWN_VISITABLE_MEMBERS(LIMITS_FOR_COMPILATION_REQUEST_MEMBERS)
|
|
};
|
|
|
|
// Enforce restriction for limit values, including:
|
|
// 1. Enforce internal Dawn constants for some limits to ensure they don't go over fixed-size
|
|
// arrays in Dawn's internal code;
|
|
// 2. Additional enforcement for dependent limits, e.g. maxStorageBufferBindingSize and
|
|
// maxUniformBufferBindingSize must not be larger than maxBufferSize.
|
|
void NormalizeLimits(Limits* limits);
|
|
|
|
} // namespace dawn::native
|
|
|
|
#endif // SRC_DAWN_NATIVE_LIMITS_H_
|