mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-05-16 12:21:35 +00:00
0d50a2c770
Deprecates the computeStage member of the descriptor in favor of compute as described by the spec. In order to support both variants without breaking backwards compatibility some code had to be manually added to the wire client to copy from the deprecated member to the new one and visa versa. Change-Id: I9d5c2fc9c446c927c5792c9af9ed56c90060b65b Bug: dawn:800 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/53884 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
98 lines
3.9 KiB
C++
98 lines
3.9 KiB
C++
// Copyright 2019 The Dawn Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include <initializer_list>
|
|
#include <limits>
|
|
#include "tests/unittests/validation/ValidationTest.h"
|
|
#include "utils/WGPUHelpers.h"
|
|
|
|
class ComputeIndirectValidationTest : public ValidationTest {
|
|
protected:
|
|
void SetUp() override {
|
|
ValidationTest::SetUp();
|
|
|
|
wgpu::ShaderModule computeModule = utils::CreateShaderModule(device, R"(
|
|
[[stage(compute), workgroup_size(1)]] fn main() {
|
|
})");
|
|
|
|
// Set up compute pipeline
|
|
wgpu::PipelineLayout pl = utils::MakeBasicPipelineLayout(device, nullptr);
|
|
|
|
wgpu::ComputePipelineDescriptor csDesc;
|
|
csDesc.layout = pl;
|
|
csDesc.compute.module = computeModule;
|
|
csDesc.compute.entryPoint = "main";
|
|
pipeline = device.CreateComputePipeline(&csDesc);
|
|
}
|
|
|
|
void ValidateExpectation(wgpu::CommandEncoder encoder, utils::Expectation expectation) {
|
|
if (expectation == utils::Expectation::Success) {
|
|
encoder.Finish();
|
|
} else {
|
|
ASSERT_DEVICE_ERROR(encoder.Finish());
|
|
}
|
|
}
|
|
|
|
void TestIndirectOffset(utils::Expectation expectation,
|
|
std::initializer_list<uint32_t> bufferList,
|
|
uint64_t indirectOffset,
|
|
wgpu::BufferUsage usage = wgpu::BufferUsage::Indirect) {
|
|
wgpu::Buffer indirectBuffer =
|
|
utils::CreateBufferFromData<uint32_t>(device, usage, bufferList);
|
|
|
|
wgpu::CommandEncoder encoder = device.CreateCommandEncoder();
|
|
wgpu::ComputePassEncoder pass = encoder.BeginComputePass();
|
|
pass.SetPipeline(pipeline);
|
|
pass.DispatchIndirect(indirectBuffer, indirectOffset);
|
|
pass.EndPass();
|
|
|
|
ValidateExpectation(encoder, expectation);
|
|
}
|
|
|
|
wgpu::ComputePipeline pipeline;
|
|
};
|
|
|
|
// Verify out of bounds indirect dispatch calls are caught early
|
|
TEST_F(ComputeIndirectValidationTest, IndirectOffsetBounds) {
|
|
// In bounds
|
|
TestIndirectOffset(utils::Expectation::Success, {1, 2, 3}, 0);
|
|
// In bounds, bigger buffer
|
|
TestIndirectOffset(utils::Expectation::Success, {1, 2, 3, 4, 5, 6}, 0);
|
|
// In bounds, bigger buffer, positive offset
|
|
TestIndirectOffset(utils::Expectation::Success, {1, 2, 3, 4, 5, 6}, 3 * sizeof(uint32_t));
|
|
|
|
// In bounds, non-multiple of 4 offsets
|
|
TestIndirectOffset(utils::Expectation::Failure, {1, 2, 3, 4}, 1);
|
|
TestIndirectOffset(utils::Expectation::Failure, {1, 2, 3, 4}, 2);
|
|
|
|
// Out of bounds, buffer too small
|
|
TestIndirectOffset(utils::Expectation::Failure, {1, 2}, 0);
|
|
// Out of bounds, index too big
|
|
TestIndirectOffset(utils::Expectation::Failure, {1, 2, 3}, 1 * sizeof(uint32_t));
|
|
// Out of bounds, index past buffer
|
|
TestIndirectOffset(utils::Expectation::Failure, {1, 2, 3}, 4 * sizeof(uint32_t));
|
|
// Out of bounds, index + size of command overflows
|
|
uint64_t offset = std::numeric_limits<uint64_t>::max();
|
|
TestIndirectOffset(utils::Expectation::Failure, {1, 2, 3, 4, 5, 6}, offset);
|
|
}
|
|
|
|
// Check that the buffer must have the indirect usage
|
|
TEST_F(ComputeIndirectValidationTest, IndirectUsage) {
|
|
// Control case: using a buffer with the indirect usage is valid.
|
|
TestIndirectOffset(utils::Expectation::Success, {1, 2, 3}, 0, wgpu::BufferUsage::Indirect);
|
|
|
|
// Error case: using a buffer with the vertex usage is an error.
|
|
TestIndirectOffset(utils::Expectation::Failure, {1, 2, 3}, 0, wgpu::BufferUsage::Vertex);
|
|
}
|