mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-05-15 03:41:34 +00:00
63cea3f8c0
This reverts commit efab8c894e30f2ef78dae59b7ce26d43d6854805. Reason for revert: breaks check_static_initializers check in Chromium https://chromium-review.googlesource.com/c/chromium/src/+/3636809/ due to the line `static Format kUnusedFormat;` in Texture.cpp. Error: file "Texture.cpp" is not expected to have static initializers in binary "chrome" # Static initializers in chrome: # 000101 _Unwind_Resume@plt # 000101 guard variable for std::__1::ios_base::Init::Init()::init_the_streams # 000101 std::__1::DoIOSInit::DoIOSInit() # 000101 std::__1::DoIOSInit::~DoIOSInit() # 000101 std::__1::ios_base::Init::Init()::init_the_streams # 000101 __cxa_atexit@plt [registers a dtor to run at exit] # 000101 __cxa_guard_abort # 000101 __cxa_guard_acquire # 000101 __cxa_guard_release # 000101 __dso_handle # InstrProfilingRuntime.cpp __llvm_profile_initialize # Texture.cpp dawn::native::Format::Format() # Texture.cpp dawn::native::kUnusedFormat # Texture.cpp __dtor__ZN4dawn6nativeL13kUnusedFormatE # Texture.cpp atexit # iostream.cpp: (empty initializer list) # Found 15 static initializers in 4 files. Original change's description: > [chromium-style] Adding constructors and destructors. > > This CL adds missing constructors and destructors. > > Bug: dawn:1405 > Change-Id: I0a0ea7ca50643d48cfc4a4dcf4ce46ff37ed10ad > Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89200 > Reviewed-by: Austin Eng <enga@chromium.org> > Kokoro: Kokoro <noreply+kokoro@google.com> > Commit-Queue: Dan Sinclair <dsinclair@chromium.org> TBR=enga@chromium.org,dsinclair@chromium.org,bclayton@google.com,noreply+kokoro@google.com,dawn-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I86daffc227c2411e8c2c69cc4683224320f4480c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: dawn:1405 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/89702 Bot-Commit: rubber-stamper@appspot.gserviceaccount.com <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Dan Sinclair <dsinclair@chromium.org>