mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-08-18 18:01:37 +00:00
4d3af66bbd
In order to preserve padding properly for MSL, we need to use its packed_vec type for all vec3 types in storage buffers, not just struct members. This commit includes a complete rewrite of the PackedVec3 transform to achieve this. The key details are: * An internal `__packed_vec3<>` type was added, which corresponds to a `type::Vector` with an additional flag to indicate that it will be emitted as packed vector. * The `PackedVec3` transform replaces all vec3 types used in host-shareable address spaces with the internal `__packed_vec3` type. This includes vec3 types that appear as the store type of a pointer. * When used as an array element, these `__packed_vec3` types are wrapped in a struct that contains a single `__packed_vec3` member. This allows us to add an `@align()` attribute that ensures that `array<vec3<T>>` still has the correct array element stride. * When the `vec3<T>` appears as a struct member in the input program, we apply the `@align()` to that member to ensure that we do not change its offset. * Matrix types with three rows that are used in memory are replaced with an array of columns, where each column uses a `__packed_vec3` inside an aligned wrapper structure as above. * Accesses to host-shareable memory that involve any of these types invoke a "pack" or "unpack" helper function to convert them to the equivalent type that uses `__packed_vec3` or a regular `vec3` as required. * The `chromium_internal_relaxed_uniform_layout` extension is used to avoid issues where modifying a type in the uniform address space triggers stricter layout validation rules. Bug: tint:1571 Fixed: tint:1837 Change-Id: Idaf2da2f5bcb2be00c85ec657edfb614186476bb Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/121200 Reviewed-by: Ben Clayton <bclayton@google.com> Commit-Queue: James Price <jrprice@google.com> Kokoro: Kokoro <noreply+kokoro@google.com>
72 lines
2.3 KiB
C++
72 lines
2.3 KiB
C++
// Copyright 2021 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
// File generated by tools/src/cmd/gen
|
|
// using the template:
|
|
// src/tint/resolver/ctor_conv_intrinsic.cc.tmpl
|
|
//
|
|
// Do not modify this file directly
|
|
////////////////////////////////////////////////////////////////////////////////
|
|
|
|
#include "src/tint/resolver/ctor_conv_intrinsic.h"
|
|
|
|
namespace tint::resolver {
|
|
|
|
const char* str(CtorConvIntrinsic i) {
|
|
switch (i) {
|
|
case CtorConvIntrinsic::kNone:
|
|
return "<none>";
|
|
case CtorConvIntrinsic::kI32:
|
|
return "i32";
|
|
case CtorConvIntrinsic::kU32:
|
|
return "u32";
|
|
case CtorConvIntrinsic::kF32:
|
|
return "f32";
|
|
case CtorConvIntrinsic::kF16:
|
|
return "f16";
|
|
case CtorConvIntrinsic::kBool:
|
|
return "bool";
|
|
case CtorConvIntrinsic::kVec2:
|
|
return "vec2";
|
|
case CtorConvIntrinsic::kVec3:
|
|
return "vec3";
|
|
case CtorConvIntrinsic::kVec4:
|
|
return "vec4";
|
|
case CtorConvIntrinsic::kMat2x2:
|
|
return "mat2x2";
|
|
case CtorConvIntrinsic::kMat2x3:
|
|
return "mat2x3";
|
|
case CtorConvIntrinsic::kMat2x4:
|
|
return "mat2x4";
|
|
case CtorConvIntrinsic::kMat3x2:
|
|
return "mat3x2";
|
|
case CtorConvIntrinsic::kMat3x3:
|
|
return "mat3x3";
|
|
case CtorConvIntrinsic::kMat3x4:
|
|
return "mat3x4";
|
|
case CtorConvIntrinsic::kMat4x2:
|
|
return "mat4x2";
|
|
case CtorConvIntrinsic::kMat4x3:
|
|
return "mat4x3";
|
|
case CtorConvIntrinsic::kMat4x4:
|
|
return "mat4x4";
|
|
case CtorConvIntrinsic::kPackedVec3:
|
|
return "packedVec3";
|
|
}
|
|
return "<unknown>";
|
|
}
|
|
|
|
} // namespace tint::resolver
|