mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-08-21 11:21:39 +00:00
42103bc2e9
This patch fixes a crash issue when the device is destroyed before
the callback of CreateReady{Render, Compute}Pipeline is called. Now
when the callback is called in DeviceBase::ShutDown(), the cached
pipeline object will also be destroyed before the callback returns.
BUG=dawn:529
TEST=dawn_end2end_tests
Change-Id: I91ec2608b53591d265c0648f5c02daf7fadac85e
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/30744
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Austin Eng <enga@chromium.org>
Commit-Queue: Jiawei Shao <jiawei.shao@intel.com>
83 lines
2.7 KiB
C++
83 lines
2.7 KiB
C++
// Copyright 2020 The Dawn Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#ifndef DAWNNATIVE_CREATEREADYPIPELINETRACKER_H_
|
|
#define DAWNNATIVE_CREATEREADYPIPELINETRACKER_H_
|
|
|
|
#include "common/SerialQueue.h"
|
|
#include "dawn/webgpu.h"
|
|
#include "dawn_native/IntegerTypes.h"
|
|
|
|
#include <memory>
|
|
|
|
namespace dawn_native {
|
|
|
|
class ComputePipelineBase;
|
|
class DeviceBase;
|
|
class PipelineBase;
|
|
class RenderPipelineBase;
|
|
|
|
struct CreateReadyPipelineTaskBase {
|
|
CreateReadyPipelineTaskBase(void* userData);
|
|
virtual ~CreateReadyPipelineTaskBase();
|
|
|
|
virtual void Finish(WGPUCreateReadyPipelineStatus status) = 0;
|
|
|
|
protected:
|
|
void* mUserData;
|
|
};
|
|
|
|
struct CreateReadyComputePipelineTask final : public CreateReadyPipelineTaskBase {
|
|
CreateReadyComputePipelineTask(ComputePipelineBase* pipeline,
|
|
WGPUCreateReadyComputePipelineCallback callback,
|
|
void* userdata);
|
|
|
|
void Finish(WGPUCreateReadyPipelineStatus status) final;
|
|
|
|
private:
|
|
ComputePipelineBase* mPipeline;
|
|
WGPUCreateReadyComputePipelineCallback mCreateReadyComputePipelineCallback;
|
|
};
|
|
|
|
struct CreateReadyRenderPipelineTask final : public CreateReadyPipelineTaskBase {
|
|
CreateReadyRenderPipelineTask(RenderPipelineBase* pipeline,
|
|
WGPUCreateReadyRenderPipelineCallback callback,
|
|
void* userdata);
|
|
|
|
void Finish(WGPUCreateReadyPipelineStatus status) final;
|
|
|
|
private:
|
|
RenderPipelineBase* mPipeline;
|
|
WGPUCreateReadyRenderPipelineCallback mCreateReadyRenderPipelineCallback;
|
|
};
|
|
|
|
class CreateReadyPipelineTracker {
|
|
public:
|
|
CreateReadyPipelineTracker(DeviceBase* device);
|
|
~CreateReadyPipelineTracker();
|
|
|
|
void TrackTask(std::unique_ptr<CreateReadyPipelineTaskBase> task, ExecutionSerial serial);
|
|
void Tick(ExecutionSerial finishedSerial);
|
|
void ClearForShutDown();
|
|
|
|
private:
|
|
DeviceBase* mDevice;
|
|
SerialQueue<ExecutionSerial, std::unique_ptr<CreateReadyPipelineTaskBase>>
|
|
mCreateReadyPipelineTasksInFlight;
|
|
};
|
|
|
|
} // namespace dawn_native
|
|
|
|
#endif
|