mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-08-18 09:51:34 +00:00
4bfe461646
Remove all redundant std::move()s. I've also removed calls to
std::move() in tests, even if they act as an optimization. This is for
two reasons:
(a) Performance is not important for testing, and this helps with
readability.
(b) A whole bunch tests were relying on std::move() clearing vectors so
they can be repopulated and used again. This is undefined behavior:
> Objects of types defined in the C++ standard library may be moved from
> (12.8). Move operations may be explicitly specified or implicitly
> generated. Unless otherwise specified, such moved-from objects shall
> be placed in a valid but unspecified state.
All of these UB cases have been fixed.
Removed all duplicate variables left over from:
`auto* foo_ptr = foo.get()`
which became:
`auto* foo_ptr = foo`
Bug: tint:322
Change-Id: Ibd08a2379671382320fd4d8da296ccc6a378b8af
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/32900
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
110 lines
2.5 KiB
C++
110 lines
2.5 KiB
C++
// Copyright 2020 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "src/ast/block_statement.h"
|
|
|
|
#include <memory>
|
|
#include <sstream>
|
|
|
|
#include "src/ast/discard_statement.h"
|
|
#include "src/ast/if_statement.h"
|
|
#include "src/ast/test_helper.h"
|
|
|
|
namespace tint {
|
|
namespace ast {
|
|
namespace {
|
|
|
|
using BlockStatementTest = TestHelper;
|
|
|
|
TEST_F(BlockStatementTest, Creation) {
|
|
auto* d = create<DiscardStatement>();
|
|
auto* ptr = d;
|
|
|
|
BlockStatement b;
|
|
b.append(d);
|
|
|
|
ASSERT_EQ(b.size(), 1u);
|
|
EXPECT_EQ(b[0], ptr);
|
|
}
|
|
|
|
TEST_F(BlockStatementTest, Creation_WithInsert) {
|
|
auto* s1 = create<DiscardStatement>();
|
|
auto* s2 = create<DiscardStatement>();
|
|
auto* s3 = create<DiscardStatement>();
|
|
|
|
BlockStatement b;
|
|
b.insert(0, s1);
|
|
b.insert(0, s2);
|
|
b.insert(1, s3);
|
|
|
|
// |b| should contain s2, s3, s1
|
|
|
|
ASSERT_EQ(b.size(), 3u);
|
|
EXPECT_EQ(b[0], s2);
|
|
EXPECT_EQ(b[1], s3);
|
|
EXPECT_EQ(b[2], s1);
|
|
}
|
|
|
|
TEST_F(BlockStatementTest, Creation_WithSource) {
|
|
BlockStatement b(Source{Source::Location{20, 2}});
|
|
auto src = b.source();
|
|
EXPECT_EQ(src.range.begin.line, 20u);
|
|
EXPECT_EQ(src.range.begin.column, 2u);
|
|
}
|
|
|
|
TEST_F(BlockStatementTest, IsBlock) {
|
|
BlockStatement b;
|
|
EXPECT_TRUE(b.IsBlock());
|
|
}
|
|
|
|
TEST_F(BlockStatementTest, IsValid) {
|
|
BlockStatement b;
|
|
b.append(create<DiscardStatement>());
|
|
EXPECT_TRUE(b.IsValid());
|
|
}
|
|
|
|
TEST_F(BlockStatementTest, IsValid_Empty) {
|
|
BlockStatement b;
|
|
EXPECT_TRUE(b.IsValid());
|
|
}
|
|
|
|
TEST_F(BlockStatementTest, IsValid_NullBodyStatement) {
|
|
BlockStatement b;
|
|
b.append(create<DiscardStatement>());
|
|
b.append(nullptr);
|
|
EXPECT_FALSE(b.IsValid());
|
|
}
|
|
|
|
TEST_F(BlockStatementTest, IsValid_InvalidBodyStatement) {
|
|
BlockStatement b;
|
|
b.append(create<IfStatement>(nullptr, create<BlockStatement>()));
|
|
EXPECT_FALSE(b.IsValid());
|
|
}
|
|
|
|
TEST_F(BlockStatementTest, ToStr) {
|
|
BlockStatement b;
|
|
b.append(create<DiscardStatement>());
|
|
|
|
std::ostringstream out;
|
|
b.to_str(out, 2);
|
|
EXPECT_EQ(out.str(), R"( Block{
|
|
Discard{}
|
|
}
|
|
)");
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace ast
|
|
} // namespace tint
|