mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-05-16 04:11:25 +00:00
c64242d4c2
RefCounted (and derived) destructors should be protected on the class to ensure the objects can ONLY be destructed by calling Release. This avoids errors cause by destroying objects out from under code which has an active reference count. Unfortunately, many of the 'base' classes must continue having public destructors because they are used as "blueprint" objects created on the stack. Added final on most-derived classes. Ideas for future improvement: - Change "base" objects to have protected destructors but create new blueprint objects that privately derive from base objects. This limits the blueprint object's usefulness to only be a blueprint. - Modify createX methods to return Ref<Object> instead of Object* Change-Id: I6f3b3b178118d135c4342cb912e982a3873d71af Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/18780 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
46 lines
1.4 KiB
C++
46 lines
1.4 KiB
C++
// Copyright 2017 The Dawn Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#ifndef DAWNNATIVE_OPENGL_COMMANDBUFFERGL_H_
|
|
#define DAWNNATIVE_OPENGL_COMMANDBUFFERGL_H_
|
|
|
|
#include "dawn_native/CommandAllocator.h"
|
|
#include "dawn_native/CommandBuffer.h"
|
|
|
|
namespace dawn_native {
|
|
struct BeginRenderPassCmd;
|
|
} // namespace dawn_native
|
|
|
|
namespace dawn_native { namespace opengl {
|
|
|
|
class Device;
|
|
|
|
class CommandBuffer final : public CommandBufferBase {
|
|
public:
|
|
CommandBuffer(CommandEncoder* encoder, const CommandBufferDescriptor* descriptor);
|
|
|
|
void Execute();
|
|
|
|
private:
|
|
~CommandBuffer() override;
|
|
void ExecuteComputePass();
|
|
void ExecuteRenderPass(BeginRenderPassCmd* renderPass);
|
|
|
|
CommandIterator mCommands;
|
|
};
|
|
|
|
}} // namespace dawn_native::opengl
|
|
|
|
#endif // DAWNNATIVE_OPENGL_COMMANDBUFFERGL_H_
|