mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-06-07 07:03:42 +00:00
This patch implements the asynchronous path of CreateComputePipelineAsync on D3D12 backend with the basic framework of the dawn_unittest AsyncTaskTest.Basic. 1. Call the constructor of dawn_native::d3d12::ComputePipeline in the main thread. 2. Execute dawn_native::ComputePipelineBase::Initialize() (a virtual function) asynchronously. 3. Ensure every operation in dawn_native::d3d12::ComputePipeline::Initialize() is thread-safe (PersistentCache). 4. Save all the return values (pipeline object or error message, userdata, etc) in a CreateComputePipelineAsyncWaitableCallbackTask object and insert this callback task into CallbackTaskManager. 5. In Callback.Finish(): - Insert the pipeline object into the pipeline cache if necessary - Call WGPUCreateComputePipelineAsyncCallback Note that as we always handle the front-end pipeline cache in the main thread, we don't need to make it thread-safe right now. BUG=dawn:529 TEST=dawn_end2end_tests Change-Id: I7eba2ce550b32439a94b2a4d1aa7f1b3383aa514 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/47900 Commit-Queue: Jiawei Shao <jiawei.shao@intel.com> Reviewed-by: Corentin Wallez <cwallez@chromium.org>
90 lines
2.9 KiB
C++
90 lines
2.9 KiB
C++
// Copyright 2021 The Dawn Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
//
|
|
// AsyncTaskTests:
|
|
// Simple tests for dawn_native::AsyncTask and dawn_native::AsnycTaskManager.
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include <memory>
|
|
#include <mutex>
|
|
|
|
#include "common/NonCopyable.h"
|
|
#include "dawn_native/AsyncTask.h"
|
|
#include "dawn_platform/DawnPlatform.h"
|
|
|
|
namespace {
|
|
|
|
struct SimpleTaskResult {
|
|
uint32_t id;
|
|
};
|
|
|
|
// A thread-safe queue that stores the task results.
|
|
class ConcurrentTaskResultQueue : public NonCopyable {
|
|
public:
|
|
void AddResult(std::unique_ptr<SimpleTaskResult> result) {
|
|
std::lock_guard<std::mutex> lock(mMutex);
|
|
mTaskResults.push_back(std::move(result));
|
|
}
|
|
|
|
std::vector<std::unique_ptr<SimpleTaskResult>> GetAllResults() {
|
|
std::vector<std::unique_ptr<SimpleTaskResult>> outputResults;
|
|
{
|
|
std::lock_guard<std::mutex> lock(mMutex);
|
|
outputResults.swap(mTaskResults);
|
|
}
|
|
return outputResults;
|
|
}
|
|
|
|
private:
|
|
std::mutex mMutex;
|
|
std::vector<std::unique_ptr<SimpleTaskResult>> mTaskResults;
|
|
};
|
|
|
|
void DoTask(ConcurrentTaskResultQueue* resultQueue, uint32_t id) {
|
|
std::unique_ptr<SimpleTaskResult> result = std::make_unique<SimpleTaskResult>();
|
|
result->id = id;
|
|
resultQueue->AddResult(std::move(result));
|
|
}
|
|
|
|
} // anonymous namespace
|
|
|
|
class AsyncTaskTest : public testing::Test {};
|
|
|
|
// Emulate the basic usage of worker thread pool in Create*PipelineAsync().
|
|
TEST_F(AsyncTaskTest, Basic) {
|
|
dawn_platform::Platform platform;
|
|
std::unique_ptr<dawn_platform::WorkerTaskPool> pool = platform.CreateWorkerTaskPool();
|
|
|
|
dawn_native::AsyncTaskManager taskManager(pool.get());
|
|
ConcurrentTaskResultQueue taskResultQueue;
|
|
|
|
constexpr size_t kTaskCount = 4u;
|
|
std::set<uint32_t> idset;
|
|
for (uint32_t i = 0; i < kTaskCount; ++i) {
|
|
dawn_native::AsyncTask asyncTask([&taskResultQueue, i] { DoTask(&taskResultQueue, i); });
|
|
taskManager.PostTask(std::move(asyncTask));
|
|
idset.insert(i);
|
|
}
|
|
|
|
taskManager.WaitAllPendingTasks();
|
|
|
|
std::vector<std::unique_ptr<SimpleTaskResult>> results = taskResultQueue.GetAllResults();
|
|
ASSERT_EQ(kTaskCount, results.size());
|
|
for (std::unique_ptr<SimpleTaskResult>& result : results) {
|
|
idset.erase(result->id);
|
|
}
|
|
ASSERT_TRUE(idset.empty());
|
|
}
|