encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
dawn-cmake/test/tint/bug/fxc/vector_assignment_in_loop
History
Antonio Maiorano 06844a5e24 tint/hlsl: remove [loop] attribute on all loops 
I added the forcing of the "loop" attribute to all loops to address FXC
failing on uniformity errors related to gradients in loops. Since then,
Tint now implements UA and it recently became an error, so we no longer
need this hack. As a result, FXC is now better able to cope with loops
that it determines executes 0 times.

Most e2e tests are affected because so many use loops, but 27 tests that
were previously failing are now passing with this change:

tint/bug/tint/1538.wgsl.expected.fxc.hlsl
tint/bug/tint/1604.wgsl.expected.fxc.hlsl
tint/bug/tint/1605.wgsl.expected.fxc.hlsl
tint/unittest/reader/spirv/SpvParserCFGTest_ClassifyCFGEdges_LoopBreak_FromLoopHeader_SingleBlockLoop_TrueBranch.spvasm.expected.fxc.hlsl
tint/unittest/reader/spirv/SpvParserCFGTest_ComputeBlockOrder_Loop_HeaderHasBreakUnless.spvasm.expected.fxc.hlsl
tint/unittest/reader/spirv/SpvParserCFGTest_EmitBody_IfSelection_TrueBranch_LoopBreak.spvasm.expected.fxc.hlsl
tint/unittest/reader/spirv/SpvParserCFGTest_FindIfSelectionInternalHeaders_TrueBranch_LoopBreak_Ok.spvasm.expected.fxc.hlsl
tint/unittest/reader/spirv/SpvParserFunctionVarTest_EmitStatement_Phi_MultiBlockLoopIndex.spvasm.expected.fxc.hlsl
tint/unittest/reader/spirv/SpvParserFunctionVarTest_EmitStatement_Phi_SingleBlockLoopIndex.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/cov-dead-code-unreachable-merge/0-opt.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/cov-dead-code-unreachable-merge/0-opt.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/similar-nested-ifs/0-opt.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/similar-nested-ifs/0-opt.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/spv-load-from-frag-color/1.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/spv-load-from-frag-color/1.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-false-if-discard-loop/0.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-false-if-discard-loop/0.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-fragcoord-less-than-zero/0.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-fragcoord-less-than-zero/0.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-fragcoord-less-than-zero/1.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-fragcoord-less-than-zero/1.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-with-loop-read-write-global/0-opt.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-with-loop-read-write-global/0-opt.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-with-loop-read-write-global/1.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/stable-binarysearch-tree-with-loop-read-write-global/1.wgsl.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/write-red-after-search/0-opt.spvasm.expected.fxc.hlsl
tint/vk-gl-cts/graphicsfuzz/write-red-after-search/0-opt.wgsl.expected.fxc.hlsl

Bug: tint:1522
Bug: tint:1538
Bug: tint:1604
Bug: tint:1605
Change-Id: I530b846b6b8df122ab351ff7b85d3e1c9ac11526
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/104121
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
 		2022-09-29 16:53:58 +00:00
..
loop_call_with_loop.wgsl Update src/tint unittests to new @stage format. 2022-06-07 13:55:34 +00:00
loop_call_with_loop.wgsl.expected.dxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
loop_call_with_loop.wgsl.expected.fxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
loop_call_with_loop.wgsl.expected.glsl
…
loop_call_with_loop.wgsl.expected.msl msl: Promote local private vars to function scope 2022-06-28 02:06:05 +00:00
loop_call_with_loop.wgsl.expected.spvasm tint/writer/spirv: Inline constant expressions 2022-06-01 15:57:22 +00:00
loop_call_with_loop.wgsl.expected.wgsl Update src/tint unittests to new @stage format. 2022-06-07 13:55:34 +00:00
loop_call_with_no_loop.wgsl Update src/tint unittests to new @stage format. 2022-06-07 13:55:34 +00:00
loop_call_with_no_loop.wgsl.expected.dxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
loop_call_with_no_loop.wgsl.expected.fxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
loop_call_with_no_loop.wgsl.expected.glsl
…
loop_call_with_no_loop.wgsl.expected.msl msl: Promote local private vars to function scope 2022-06-28 02:06:05 +00:00
loop_call_with_no_loop.wgsl.expected.spvasm tint/writer/spirv: Inline constant expressions 2022-06-01 15:57:22 +00:00
loop_call_with_no_loop.wgsl.expected.wgsl Update src/tint unittests to new @stage format. 2022-06-07 13:55:34 +00:00
loop_types_all.wgsl Update src/tint unittests to new @stage format. 2022-06-07 13:55:34 +00:00
loop_types_all.wgsl.expected.dxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
loop_types_all.wgsl.expected.fxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
loop_types_all.wgsl.expected.glsl
…
loop_types_all.wgsl.expected.msl
…
loop_types_all.wgsl.expected.spvasm tint/writer/spirv: Inline constant expressions 2022-06-01 15:57:22 +00:00
loop_types_all.wgsl.expected.wgsl Update src/tint unittests to new @stage format. 2022-06-07 13:55:34 +00:00
loop_types_repeated.wgsl Update src/tint unittests to new @stage format. 2022-06-07 13:55:34 +00:00
loop_types_repeated.wgsl.expected.dxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
loop_types_repeated.wgsl.expected.fxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
loop_types_repeated.wgsl.expected.glsl
…
loop_types_repeated.wgsl.expected.msl
…
loop_types_repeated.wgsl.expected.spvasm tint/writer/spirv: Inline constant expressions 2022-06-01 15:57:22 +00:00
loop_types_repeated.wgsl.expected.wgsl Update src/tint unittests to new @stage format. 2022-06-07 13:55:34 +00:00
loop_types_some.wgsl Update src/tint unittests to new @stage format. 2022-06-07 13:55:34 +00:00
loop_types_some.wgsl.expected.dxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
loop_types_some.wgsl.expected.fxc.hlsl tint/hlsl: remove [loop] attribute on all loops 2022-09-29 16:53:58 +00:00
loop_types_some.wgsl.expected.glsl
…
loop_types_some.wgsl.expected.msl
…
loop_types_some.wgsl.expected.spvasm tint/writer/spirv: Inline constant expressions 2022-06-01 15:57:22 +00:00
loop_types_some.wgsl.expected.wgsl Update src/tint unittests to new @stage format. 2022-06-07 13:55:34 +00:00
no_loop.wgsl Update src/tint unittests to new @stage format. 2022-06-07 13:55:34 +00:00
no_loop.wgsl.expected.dxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
no_loop.wgsl.expected.fxc.hlsl tint/test-runner: Split expectations for FXC and DXC 2022-07-22 17:43:27 +00:00
no_loop.wgsl.expected.glsl
…
no_loop.wgsl.expected.msl
…
no_loop.wgsl.expected.spvasm tint/writer/spirv: Inline constant expressions 2022-06-01 15:57:22 +00:00
no_loop.wgsl.expected.wgsl Update src/tint unittests to new @stage format. 2022-06-07 13:55:34 +00:00