mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-08-22 19:52:00 +00:00
- Adds testing for Vulkan pipeline caching. - Removed redundant VK_NULL_HANDLE and use explicit {} initialization for 0 handles when necessary. - Adds some const qualifiers where applicable and useful. - Removes overloaded GetCacheKey (const/non-const) versions and exposed the cache key member directly for modifiers in derived classes. Bug: dawn:549 Change-Id: I5e8ab9716eebc916b813c9d032f8dc1f3f5261bc Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/86581 Commit-Queue: Loko Kung <lokokung@google.com> Reviewed-by: Austin Eng <enga@chromium.org> Kokoro: Kokoro <noreply+kokoro@google.com>
98 lines
3.3 KiB
C++
98 lines
3.3 KiB
C++
// Copyright 2017 The Dawn Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "dawn/native/ComputePipeline.h"
|
|
|
|
#include "dawn/native/Device.h"
|
|
#include "dawn/native/ObjectContentHasher.h"
|
|
#include "dawn/native/ObjectType_autogen.h"
|
|
|
|
namespace dawn::native {
|
|
|
|
MaybeError ValidateComputePipelineDescriptor(DeviceBase* device,
|
|
const ComputePipelineDescriptor* descriptor) {
|
|
if (descriptor->nextInChain != nullptr) {
|
|
return DAWN_FORMAT_VALIDATION_ERROR("nextInChain must be nullptr.");
|
|
}
|
|
|
|
if (descriptor->layout != nullptr) {
|
|
DAWN_TRY(device->ValidateObject(descriptor->layout));
|
|
}
|
|
|
|
return ValidateProgrammableStage(
|
|
device, descriptor->compute.module, descriptor->compute.entryPoint,
|
|
descriptor->compute.constantCount, descriptor->compute.constants, descriptor->layout,
|
|
SingleShaderStage::Compute);
|
|
}
|
|
|
|
// ComputePipelineBase
|
|
|
|
ComputePipelineBase::ComputePipelineBase(DeviceBase* device,
|
|
const ComputePipelineDescriptor* descriptor)
|
|
: PipelineBase(
|
|
device,
|
|
descriptor->layout,
|
|
descriptor->label,
|
|
{{SingleShaderStage::Compute, descriptor->compute.module, descriptor->compute.entryPoint,
|
|
descriptor->compute.constantCount, descriptor->compute.constants}}) {
|
|
SetContentHash(ComputeContentHash());
|
|
TrackInDevice();
|
|
|
|
// Initialize the cache key to include the cache type and device information.
|
|
mCacheKey.Record(CacheKey::Type::ComputePipeline, device->GetCacheKey());
|
|
}
|
|
|
|
ComputePipelineBase::ComputePipelineBase(DeviceBase* device) : PipelineBase(device) {
|
|
TrackInDevice();
|
|
}
|
|
|
|
ComputePipelineBase::ComputePipelineBase(DeviceBase* device, ObjectBase::ErrorTag tag)
|
|
: PipelineBase(device, tag) {}
|
|
|
|
ComputePipelineBase::~ComputePipelineBase() = default;
|
|
|
|
void ComputePipelineBase::DestroyImpl() {
|
|
if (IsCachedReference()) {
|
|
// Do not uncache the actual cached object if we are a blueprint.
|
|
GetDevice()->UncacheComputePipeline(this);
|
|
}
|
|
}
|
|
|
|
// static
|
|
ComputePipelineBase* ComputePipelineBase::MakeError(DeviceBase* device) {
|
|
class ErrorComputePipeline final : public ComputePipelineBase {
|
|
public:
|
|
explicit ErrorComputePipeline(DeviceBase* device)
|
|
: ComputePipelineBase(device, ObjectBase::kError) {}
|
|
|
|
MaybeError Initialize() override {
|
|
UNREACHABLE();
|
|
return {};
|
|
}
|
|
};
|
|
|
|
return new ErrorComputePipeline(device);
|
|
}
|
|
|
|
ObjectType ComputePipelineBase::GetType() const {
|
|
return ObjectType::ComputePipeline;
|
|
}
|
|
|
|
bool ComputePipelineBase::EqualityFunc::operator()(const ComputePipelineBase* a,
|
|
const ComputePipelineBase* b) const {
|
|
return PipelineBase::EqualForCache(a, b);
|
|
}
|
|
|
|
} // namespace dawn::native
|