Antonio Maiorano
d733fdb85c
HLSL: work around FXC failures when dynamically indexing arrays in structs
...
FXC fails to compile code that assigns to dynamically-indexed fixed-size
arrays in structs on internal shader variables with:
error X3500: array reference cannot be used as an l-value; not natively
addressable
This CL detects this case, and transforms such assignments into copying
out the array to a local variable, assigning to that local, and then
copying the array back.
Also manually regenerate SKIPs for HLSL/FXC after this change, which
fixes 30 tests. Also exposes some "compilation aborted unexpectedly" now
that "array reference cannot be used as an l-value" has been fixed. For
tests that fail for both DXC and FXC, updating SKIPs to the DXC one to
help distinguish actual FXC bugs from valid errors.
Bug: tint:998
Bug: tint:1206
Change-Id: I09204d8d81ab27d1c257538ad702414ccc386543
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/71620
Reviewed-by: Ben Clayton <bclayton@google.com>
Kokoro: Kokoro <noreply+kokoro@google.com>
Commit-Queue: Antonio Maiorano <amaiorano@google.com>
2021-12-13 15:55:11 +00:00
..
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-13 15:55:11 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-13 15:55:11 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-13 15:55:11 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-13 15:55:11 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-08-24 22:49:42 +00:00
2021-08-24 22:49:42 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-08 23:03:33 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-13 15:55:11 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-13 15:55:11 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-08-24 22:49:42 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-13 15:55:11 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-11-04 19:55:57 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-13 15:55:11 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-08-24 22:49:42 +00:00
2021-12-13 15:55:11 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-08 04:26:58 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-13 15:55:11 +00:00
2021-12-13 15:55:11 +00:00
2021-12-09 15:45:03 +00:00
2021-12-13 15:55:11 +00:00
2021-12-08 04:26:58 +00:00
2021-12-09 15:45:03 +00:00
2021-12-13 15:55:11 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-13 15:55:11 +00:00
2021-12-13 15:55:11 +00:00
2021-12-13 15:55:11 +00:00
2021-12-13 15:55:11 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-13 15:55:11 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-09 15:45:03 +00:00
2021-12-13 15:55:11 +00:00
2021-08-24 22:49:42 +00:00
2021-12-13 15:55:11 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-08-24 22:49:42 +00:00
2021-12-09 15:45:03 +00:00
2021-12-13 15:55:11 +00:00
2021-12-13 15:55:11 +00:00
2021-12-08 23:03:33 +00:00
2021-12-09 15:45:03 +00:00