encounter
/
dawn-cmake
mirror of https://github.com/encounter/dawn-cmake.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
dawn-cmake/test/tint/ptr_ref/store/param/private
History
James Price 0e22bdbae7 tint/msl: Fix emission of private variables 
In order to avoid declaring too many function parameters, we
previously modified this transform to redeclare private variables that
are only used inside a single function as function-scope
variables. This was broken as it meant that their values did not
persist across multiple calls to the same function.

Instead, wrap all private variables in a structure and pass it around
as a pointer.

Fixed: tint:1875
Change-Id: I83f5eb1071d57b9c6af56d6cf21b3a32c6e94260
Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/124800
Kokoro: Kokoro <noreply+kokoro@google.com>
Reviewed-by: Ben Clayton <bclayton@google.com>
Commit-Queue: James Price <jrprice@google.com>
 		2023-03-20 21:46:01 +00:00
..
array_in_struct.wgsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
array_in_struct.wgsl.expected.dxc.hlsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
array_in_struct.wgsl.expected.fxc.hlsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
array_in_struct.wgsl.expected.glsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
array_in_struct.wgsl.expected.msl tint/msl: Fix emission of private variables 2023-03-20 21:46:01 +00:00
array_in_struct.wgsl.expected.spvasm tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
array_in_struct.wgsl.expected.wgsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
i32.wgsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
i32.wgsl.expected.dxc.hlsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
i32.wgsl.expected.fxc.hlsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
i32.wgsl.expected.glsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
i32.wgsl.expected.msl tint/msl: Fix emission of private variables 2023-03-20 21:46:01 +00:00
i32.wgsl.expected.spvasm tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
i32.wgsl.expected.wgsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
i32_in_struct.wgsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
i32_in_struct.wgsl.expected.dxc.hlsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
i32_in_struct.wgsl.expected.fxc.hlsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
i32_in_struct.wgsl.expected.glsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
i32_in_struct.wgsl.expected.msl tint/msl: Fix emission of private variables 2023-03-20 21:46:01 +00:00
i32_in_struct.wgsl.expected.spvasm tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
i32_in_struct.wgsl.expected.wgsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
struct_in_array.wgsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
struct_in_array.wgsl.expected.dxc.hlsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
struct_in_array.wgsl.expected.fxc.hlsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
struct_in_array.wgsl.expected.glsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
struct_in_array.wgsl.expected.msl tint/msl: Fix emission of private variables 2023-03-20 21:46:01 +00:00
struct_in_array.wgsl.expected.spvasm tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
struct_in_array.wgsl.expected.wgsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec2_f32_in_mat2x2.wgsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec2_f32_in_mat2x2.wgsl.expected.dxc.hlsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec2_f32_in_mat2x2.wgsl.expected.fxc.hlsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec2_f32_in_mat2x2.wgsl.expected.glsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec2_f32_in_mat2x2.wgsl.expected.msl tint/msl: Fix emission of private variables 2023-03-20 21:46:01 +00:00
vec2_f32_in_mat2x2.wgsl.expected.spvasm tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec2_f32_in_mat2x2.wgsl.expected.wgsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec4_f32.wgsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec4_f32.wgsl.expected.dxc.hlsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec4_f32.wgsl.expected.fxc.hlsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec4_f32.wgsl.expected.glsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec4_f32.wgsl.expected.msl tint/msl: Fix emission of private variables 2023-03-20 21:46:01 +00:00
vec4_f32.wgsl.expected.spvasm tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec4_f32.wgsl.expected.wgsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec4_f32_in_mat2x4.wgsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec4_f32_in_mat2x4.wgsl.expected.dxc.hlsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec4_f32_in_mat2x4.wgsl.expected.fxc.hlsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec4_f32_in_mat2x4.wgsl.expected.glsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec4_f32_in_mat2x4.wgsl.expected.msl tint/msl: Fix emission of private variables 2023-03-20 21:46:01 +00:00
vec4_f32_in_mat2x4.wgsl.expected.spvasm tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec4_f32_in_mat2x4.wgsl.expected.wgsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec4_f32_in_struct.wgsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec4_f32_in_struct.wgsl.expected.dxc.hlsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec4_f32_in_struct.wgsl.expected.fxc.hlsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec4_f32_in_struct.wgsl.expected.glsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec4_f32_in_struct.wgsl.expected.msl tint/msl: Fix emission of private variables 2023-03-20 21:46:01 +00:00
vec4_f32_in_struct.wgsl.expected.spvasm tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00
vec4_f32_in_struct.wgsl.expected.wgsl tint: Add DirectVariableAccess transform 2022-12-01 18:49:09 +00:00