mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-07-09 06:35:54 +00:00
ed2b97811e
Deep-clones all `Node`s and `Type`s into a new module.
Instead of writing a million standalone tests that'll only ever test the
existing fields of each type, I've opted to write the tests using
wgsl<->ast<->wgsl conversion. This means the tests require the enabling
of TINT_BUILD_WGSL_READER and TINT_BUILD_WGSL_WRITER, but I believe this
is much easier to maintain.
I'm aware there are probably gaps in the tests, and that even full
coverage is likely to rapidly rot, so I've also added
fuzzers/tint_ast_clone_fuzzer.cc - a fuzzer based test that ensures that
all AST modules can be cloned with identical reproduction.
I've run this across 100 cores of a 3990x for 4 hours, fixing the
single issue it detected.
Note: Expressions do not currently clone their `TypeManager` determined
types. This is for two reasons:
(a) This initial CL is mahoosive enough.
(b) I'm uncertain whether we actually want to clone this info, or to
re-run the `TypeDeterminer` after each AST transform. Maybe it should
be optional. Time will tell.
Fixed: tint:307
Change-Id: Id90fab06aaa740c805d12b66f3f11d1f452c6805
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/33300
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: dan sinclair <dsinclair@chromium.org>
Reviewed-by: David Neto <dneto@google.com>
58 lines
1.8 KiB
C++
58 lines
1.8 KiB
C++
// Copyright 2020 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#ifndef SRC_AST_CONSTANT_ID_DECORATION_H_
|
|
#define SRC_AST_CONSTANT_ID_DECORATION_H_
|
|
|
|
#include "src/ast/builtin.h"
|
|
#include "src/ast/variable_decoration.h"
|
|
|
|
namespace tint {
|
|
namespace ast {
|
|
|
|
/// A constant id decoration
|
|
class ConstantIdDecoration
|
|
: public Castable<ConstantIdDecoration, VariableDecoration> {
|
|
public:
|
|
/// constructor
|
|
/// @param val the constant_id value
|
|
/// @param source the source of this decoration
|
|
ConstantIdDecoration(uint32_t val, const Source& source);
|
|
~ConstantIdDecoration() override;
|
|
|
|
/// @returns the constant id value
|
|
uint32_t value() const { return value_; }
|
|
|
|
/// Outputs the decoration to the given stream
|
|
/// @param out the stream to write to
|
|
/// @param indent number of spaces to indent the node when writing
|
|
void to_str(std::ostream& out, size_t indent) const override;
|
|
|
|
/// Clones this node and all transitive child nodes using the `CloneContext`
|
|
/// `ctx`.
|
|
/// @note Semantic information such as resolved expression type and intrinsic
|
|
/// information is not cloned.
|
|
/// @param ctx the clone context
|
|
/// @return the newly cloned node
|
|
ConstantIdDecoration* Clone(CloneContext* ctx) const override;
|
|
|
|
private:
|
|
uint32_t value_ = 0;
|
|
};
|
|
|
|
} // namespace ast
|
|
} // namespace tint
|
|
|
|
#endif // SRC_AST_CONSTANT_ID_DECORATION_H_
|