mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-07-05 04:36:02 +00:00
This change implements timeline fences in Dawn. It includes methods and descriptor members to eventually support multi-queue, but does not implement them. Bug: dawn:26 Change-Id: I81d5fee6acef402fe099227a034d9669a89ab6c3 Reviewed-on: https://dawn-review.googlesource.com/c/2460 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org>
228 lines
7.7 KiB
C++
228 lines
7.7 KiB
C++
// Copyright 2018 The Dawn Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include <gmock/gmock.h>
|
|
#include "tests/DawnTest.h"
|
|
|
|
#include <array>
|
|
#include <cstring>
|
|
|
|
class MockFenceOnCompletionCallback {
|
|
public:
|
|
MOCK_METHOD2(Call, void(dawnFenceCompletionStatus status, dawnCallbackUserdata userdata));
|
|
};
|
|
|
|
static std::unique_ptr<MockFenceOnCompletionCallback> mockFenceOnCompletionCallback;
|
|
static void ToMockFenceOnCompletionCallback(dawnFenceCompletionStatus status,
|
|
dawnCallbackUserdata userdata) {
|
|
mockFenceOnCompletionCallback->Call(status, userdata);
|
|
}
|
|
class FenceTests : public DawnTest {
|
|
private:
|
|
struct CallbackInfo {
|
|
FenceTests* test;
|
|
uint64_t value;
|
|
dawnFenceCompletionStatus status;
|
|
int32_t callIndex = -1; // If this is -1, the callback was not called
|
|
|
|
void Update(dawnFenceCompletionStatus status) {
|
|
this->callIndex = test->mCallIndex++;
|
|
this->status = status;
|
|
}
|
|
};
|
|
|
|
int32_t mCallIndex;
|
|
|
|
protected:
|
|
FenceTests() : mCallIndex(0) {
|
|
}
|
|
|
|
void SetUp() override {
|
|
DawnTest::SetUp();
|
|
mockFenceOnCompletionCallback = std::make_unique<MockFenceOnCompletionCallback>();
|
|
}
|
|
|
|
void TearDown() override {
|
|
mockFenceOnCompletionCallback = nullptr;
|
|
DawnTest::TearDown();
|
|
}
|
|
|
|
void WaitForCompletedValue(dawn::Fence fence, uint64_t completedValue) {
|
|
while (fence.GetCompletedValue() < completedValue) {
|
|
WaitABit();
|
|
}
|
|
}
|
|
};
|
|
|
|
// Test that signaling a fence updates the completed value
|
|
TEST_P(FenceTests, SimpleSignal) {
|
|
dawn::FenceDescriptor descriptor;
|
|
descriptor.initialValue = 1u;
|
|
dawn::Fence fence = device.CreateFence(&descriptor);
|
|
|
|
// Completed value starts at initial value
|
|
EXPECT_EQ(fence.GetCompletedValue(), 1u);
|
|
|
|
queue.Signal(fence, 2);
|
|
WaitForCompletedValue(fence, 2);
|
|
|
|
// Completed value updates to signaled value
|
|
EXPECT_EQ(fence.GetCompletedValue(), 2u);
|
|
}
|
|
|
|
// Test callbacks are called in increasing order of fence completion value
|
|
TEST_P(FenceTests, OnCompletionOrdering) {
|
|
dawn::FenceDescriptor descriptor;
|
|
descriptor.initialValue = 0u;
|
|
dawn::Fence fence = device.CreateFence(&descriptor);
|
|
|
|
queue.Signal(fence, 4);
|
|
|
|
dawnCallbackUserdata userdata0 = 1282;
|
|
dawnCallbackUserdata userdata1 = 4382;
|
|
dawnCallbackUserdata userdata2 = 1211;
|
|
dawnCallbackUserdata userdata3 = 1882;
|
|
|
|
{
|
|
testing::InSequence s;
|
|
|
|
EXPECT_CALL(*mockFenceOnCompletionCallback,
|
|
Call(DAWN_FENCE_COMPLETION_STATUS_SUCCESS, userdata0))
|
|
.Times(1);
|
|
|
|
EXPECT_CALL(*mockFenceOnCompletionCallback,
|
|
Call(DAWN_FENCE_COMPLETION_STATUS_SUCCESS, userdata1))
|
|
.Times(1);
|
|
|
|
EXPECT_CALL(*mockFenceOnCompletionCallback,
|
|
Call(DAWN_FENCE_COMPLETION_STATUS_SUCCESS, userdata2))
|
|
.Times(1);
|
|
|
|
EXPECT_CALL(*mockFenceOnCompletionCallback,
|
|
Call(DAWN_FENCE_COMPLETION_STATUS_SUCCESS, userdata3))
|
|
.Times(1);
|
|
}
|
|
|
|
fence.OnCompletion(2u, ToMockFenceOnCompletionCallback, userdata2);
|
|
fence.OnCompletion(0u, ToMockFenceOnCompletionCallback, userdata0);
|
|
fence.OnCompletion(3u, ToMockFenceOnCompletionCallback, userdata3);
|
|
fence.OnCompletion(1u, ToMockFenceOnCompletionCallback, userdata1);
|
|
|
|
WaitForCompletedValue(fence, 4);
|
|
}
|
|
|
|
// Test callbacks still occur if Queue::Signal happens multiple times
|
|
TEST_P(FenceTests, MultipleSignalOnCompletion) {
|
|
dawn::FenceDescriptor descriptor;
|
|
descriptor.initialValue = 0u;
|
|
dawn::Fence fence = device.CreateFence(&descriptor);
|
|
|
|
queue.Signal(fence, 2);
|
|
queue.Signal(fence, 4);
|
|
|
|
dawnCallbackUserdata userdata = 1234;
|
|
EXPECT_CALL(*mockFenceOnCompletionCallback,
|
|
Call(DAWN_FENCE_COMPLETION_STATUS_SUCCESS, userdata))
|
|
.Times(1);
|
|
fence.OnCompletion(3u, ToMockFenceOnCompletionCallback, userdata);
|
|
|
|
WaitForCompletedValue(fence, 4);
|
|
}
|
|
|
|
// Test all callbacks are called if they are added for the same fence value
|
|
TEST_P(FenceTests, OnCompletionMultipleCallbacks) {
|
|
dawn::FenceDescriptor descriptor;
|
|
descriptor.initialValue = 0u;
|
|
dawn::Fence fence = device.CreateFence(&descriptor);
|
|
|
|
queue.Signal(fence, 4);
|
|
|
|
dawnCallbackUserdata userdata0 = 2341;
|
|
dawnCallbackUserdata userdata1 = 4598;
|
|
dawnCallbackUserdata userdata2 = 5690;
|
|
dawnCallbackUserdata userdata3 = 2783;
|
|
|
|
EXPECT_CALL(*mockFenceOnCompletionCallback,
|
|
Call(DAWN_FENCE_COMPLETION_STATUS_SUCCESS, userdata0))
|
|
.Times(1);
|
|
|
|
EXPECT_CALL(*mockFenceOnCompletionCallback,
|
|
Call(DAWN_FENCE_COMPLETION_STATUS_SUCCESS, userdata1))
|
|
.Times(1);
|
|
|
|
EXPECT_CALL(*mockFenceOnCompletionCallback,
|
|
Call(DAWN_FENCE_COMPLETION_STATUS_SUCCESS, userdata2))
|
|
.Times(1);
|
|
|
|
EXPECT_CALL(*mockFenceOnCompletionCallback,
|
|
Call(DAWN_FENCE_COMPLETION_STATUS_SUCCESS, userdata3))
|
|
.Times(1);
|
|
|
|
fence.OnCompletion(4u, ToMockFenceOnCompletionCallback, userdata0);
|
|
fence.OnCompletion(4u, ToMockFenceOnCompletionCallback, userdata1);
|
|
fence.OnCompletion(4u, ToMockFenceOnCompletionCallback, userdata2);
|
|
fence.OnCompletion(4u, ToMockFenceOnCompletionCallback, userdata3);
|
|
|
|
WaitForCompletedValue(fence, 4u);
|
|
}
|
|
|
|
// TODO(enga): Enable when fence is removed from fence signal tracker
|
|
// Currently it holds a reference and is not destructed
|
|
TEST_P(FenceTests, DISABLED_DestroyBeforeOnCompletionEnd) {
|
|
dawn::FenceDescriptor descriptor;
|
|
descriptor.initialValue = 0u;
|
|
dawn::Fence fence = device.CreateFence(&descriptor);
|
|
|
|
// The fence in this block will be deleted when it goes out of scope
|
|
{
|
|
dawn::FenceDescriptor descriptor;
|
|
descriptor.initialValue = 0u;
|
|
dawn::Fence testFence = device.CreateFence(&descriptor);
|
|
|
|
queue.Signal(testFence, 4);
|
|
|
|
dawnCallbackUserdata userdata0 = 1341;
|
|
dawnCallbackUserdata userdata1 = 1598;
|
|
dawnCallbackUserdata userdata2 = 1690;
|
|
dawnCallbackUserdata userdata3 = 1783;
|
|
|
|
EXPECT_CALL(*mockFenceOnCompletionCallback,
|
|
Call(DAWN_FENCE_COMPLETION_STATUS_UNKNOWN, userdata0))
|
|
.Times(1);
|
|
|
|
EXPECT_CALL(*mockFenceOnCompletionCallback,
|
|
Call(DAWN_FENCE_COMPLETION_STATUS_UNKNOWN, userdata1))
|
|
.Times(1);
|
|
|
|
EXPECT_CALL(*mockFenceOnCompletionCallback,
|
|
Call(DAWN_FENCE_COMPLETION_STATUS_UNKNOWN, userdata2))
|
|
.Times(1);
|
|
|
|
EXPECT_CALL(*mockFenceOnCompletionCallback,
|
|
Call(DAWN_FENCE_COMPLETION_STATUS_UNKNOWN, userdata3))
|
|
.Times(1);
|
|
|
|
testFence.OnCompletion(1u, ToMockFenceOnCompletionCallback, userdata0);
|
|
testFence.OnCompletion(2u, ToMockFenceOnCompletionCallback, userdata1);
|
|
testFence.OnCompletion(2u, ToMockFenceOnCompletionCallback, userdata2);
|
|
testFence.OnCompletion(3u, ToMockFenceOnCompletionCallback, userdata3);
|
|
}
|
|
|
|
// Wait for another fence to be sure all callbacks have cleared
|
|
queue.Signal(fence, 1);
|
|
WaitForCompletedValue(fence, 1);
|
|
}
|
|
|
|
DAWN_INSTANTIATE_TEST(FenceTests, D3D12Backend, MetalBackend, OpenGLBackend, VulkanBackend)
|