mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-08-03 10:45:36 +00:00
1c85976abe
For samplers with NaN mLodMinClamp or mLodMaxClamp, the equality operator returned false. Adds checks for finite values, and also early returns if two pointers are equal. Bug: dawn:143, chromium:965633 Change-Id: Id5998d6eec275af0fbe30e3b4fcb3eed4fe64c6a Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/7401 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Idan Raiter <idanr@google.com>
50 lines
1.8 KiB
C++
50 lines
1.8 KiB
C++
// Copyright 2019 The Dawn Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "tests/unittests/validation/ValidationTest.h"
|
|
|
|
#include "utils/DawnHelpers.h"
|
|
|
|
#include <cmath>
|
|
|
|
namespace {
|
|
|
|
class SamplerValidationTest : public ValidationTest {};
|
|
|
|
// Test NaN and INFINITY values are not allowed
|
|
TEST_F(SamplerValidationTest, InvalidLOD) {
|
|
{
|
|
dawn::SamplerDescriptor samplerDesc = utils::GetDefaultSamplerDescriptor();
|
|
samplerDesc.lodMinClamp = NAN;
|
|
ASSERT_DEVICE_ERROR(device.CreateSampler(&samplerDesc));
|
|
}
|
|
{
|
|
dawn::SamplerDescriptor samplerDesc = utils::GetDefaultSamplerDescriptor();
|
|
samplerDesc.lodMaxClamp = NAN;
|
|
ASSERT_DEVICE_ERROR(device.CreateSampler(&samplerDesc));
|
|
}
|
|
{
|
|
dawn::SamplerDescriptor samplerDesc = utils::GetDefaultSamplerDescriptor();
|
|
samplerDesc.lodMinClamp = INFINITY;
|
|
ASSERT_DEVICE_ERROR(device.CreateSampler(&samplerDesc));
|
|
}
|
|
{
|
|
dawn::SamplerDescriptor samplerDesc = utils::GetDefaultSamplerDescriptor();
|
|
samplerDesc.lodMaxClamp = INFINITY;
|
|
ASSERT_DEVICE_ERROR(device.CreateSampler(&samplerDesc));
|
|
}
|
|
}
|
|
|
|
} // anonymous namespace
|