163 lines
7.2 KiB
C++
163 lines
7.2 KiB
C++
// Copyright 2019 The Dawn Authors
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include <initializer_list>
|
|
#include <limits>
|
|
#include "dawn/tests/unittests/validation/ValidationTest.h"
|
|
#include "dawn/utils/ComboRenderPipelineDescriptor.h"
|
|
#include "dawn/utils/WGPUHelpers.h"
|
|
|
|
class DrawIndirectValidationTest : public ValidationTest {
|
|
protected:
|
|
void SetUp() override {
|
|
ValidationTest::SetUp();
|
|
|
|
wgpu::ShaderModule vsModule = utils::CreateShaderModule(device, R"(
|
|
@stage(vertex) fn main() -> @builtin(position) vec4<f32> {
|
|
return vec4<f32>(0.0, 0.0, 0.0, 0.0);
|
|
})");
|
|
|
|
wgpu::ShaderModule fsModule = utils::CreateShaderModule(device, R"(
|
|
@stage(fragment) fn main() -> @location(0) vec4<f32>{
|
|
return vec4<f32>(0.0, 0.0, 0.0, 0.0);
|
|
})");
|
|
|
|
// Set up render pipeline
|
|
wgpu::PipelineLayout pipelineLayout = utils::MakeBasicPipelineLayout(device, nullptr);
|
|
|
|
utils::ComboRenderPipelineDescriptor descriptor;
|
|
descriptor.layout = pipelineLayout;
|
|
descriptor.vertex.module = vsModule;
|
|
descriptor.cFragment.module = fsModule;
|
|
|
|
pipeline = device.CreateRenderPipeline(&descriptor);
|
|
}
|
|
|
|
void ValidateExpectation(wgpu::CommandEncoder encoder, utils::Expectation expectation) {
|
|
if (expectation == utils::Expectation::Success) {
|
|
encoder.Finish();
|
|
} else {
|
|
ASSERT_DEVICE_ERROR(encoder.Finish());
|
|
}
|
|
}
|
|
|
|
void TestIndirectOffsetDrawIndexed(utils::Expectation expectation,
|
|
std::initializer_list<uint32_t> bufferList,
|
|
uint64_t indirectOffset) {
|
|
TestIndirectOffset(expectation, bufferList, indirectOffset, true);
|
|
}
|
|
|
|
void TestIndirectOffsetDraw(utils::Expectation expectation,
|
|
std::initializer_list<uint32_t> bufferList,
|
|
uint64_t indirectOffset) {
|
|
TestIndirectOffset(expectation, bufferList, indirectOffset, false);
|
|
}
|
|
|
|
void TestIndirectOffset(utils::Expectation expectation,
|
|
std::initializer_list<uint32_t> bufferList,
|
|
uint64_t indirectOffset,
|
|
bool indexed,
|
|
wgpu::BufferUsage usage = wgpu::BufferUsage::Indirect) {
|
|
wgpu::Buffer indirectBuffer =
|
|
utils::CreateBufferFromData<uint32_t>(device, usage, bufferList);
|
|
|
|
PlaceholderRenderPass renderPass(device);
|
|
wgpu::CommandEncoder encoder = device.CreateCommandEncoder();
|
|
wgpu::RenderPassEncoder pass = encoder.BeginRenderPass(&renderPass);
|
|
pass.SetPipeline(pipeline);
|
|
if (indexed) {
|
|
uint32_t zeros[100] = {};
|
|
wgpu::Buffer indexBuffer =
|
|
utils::CreateBufferFromData(device, zeros, sizeof(zeros), wgpu::BufferUsage::Index);
|
|
pass.SetIndexBuffer(indexBuffer, wgpu::IndexFormat::Uint32);
|
|
pass.DrawIndexedIndirect(indirectBuffer, indirectOffset);
|
|
} else {
|
|
pass.DrawIndirect(indirectBuffer, indirectOffset);
|
|
}
|
|
pass.End();
|
|
|
|
ValidateExpectation(encoder, expectation);
|
|
}
|
|
|
|
wgpu::RenderPipeline pipeline;
|
|
};
|
|
|
|
// Verify out of bounds indirect draw calls are caught early
|
|
TEST_F(DrawIndirectValidationTest, DrawIndirectOffsetBounds) {
|
|
// In bounds
|
|
TestIndirectOffsetDraw(utils::Expectation::Success, {1, 2, 3, 4}, 0);
|
|
// In bounds, bigger buffer
|
|
TestIndirectOffsetDraw(utils::Expectation::Success, {1, 2, 3, 4, 5, 6, 7}, 0);
|
|
// In bounds, bigger buffer, positive offset
|
|
TestIndirectOffsetDraw(utils::Expectation::Success, {1, 2, 3, 4, 5, 6, 7, 8},
|
|
4 * sizeof(uint32_t));
|
|
|
|
// In bounds, non-multiple of 4 offsets
|
|
TestIndirectOffsetDraw(utils::Expectation::Failure, {1, 2, 3, 4, 5}, 1);
|
|
TestIndirectOffsetDraw(utils::Expectation::Failure, {1, 2, 3, 4, 5}, 2);
|
|
|
|
// Out of bounds, buffer too small
|
|
TestIndirectOffsetDraw(utils::Expectation::Failure, {1, 2, 3}, 0);
|
|
// Out of bounds, index too big
|
|
TestIndirectOffsetDraw(utils::Expectation::Failure, {1, 2, 3, 4}, 1 * sizeof(uint32_t));
|
|
// Out of bounds, index past buffer
|
|
TestIndirectOffsetDraw(utils::Expectation::Failure, {1, 2, 3, 4}, 5 * sizeof(uint32_t));
|
|
// Out of bounds, index + size of command overflows
|
|
uint64_t offset = std::numeric_limits<uint64_t>::max();
|
|
TestIndirectOffsetDraw(utils::Expectation::Failure, {1, 2, 3, 4, 5, 6, 7}, offset);
|
|
}
|
|
|
|
// Verify out of bounds indirect draw indexed calls are caught early
|
|
TEST_F(DrawIndirectValidationTest, DrawIndexedIndirectOffsetBounds) {
|
|
// In bounds
|
|
TestIndirectOffsetDrawIndexed(utils::Expectation::Success, {1, 2, 3, 4, 5}, 0);
|
|
// In bounds, bigger buffer
|
|
TestIndirectOffsetDrawIndexed(utils::Expectation::Success, {1, 2, 3, 4, 5, 6, 7, 8, 9}, 0);
|
|
// In bounds, bigger buffer, positive offset
|
|
TestIndirectOffsetDrawIndexed(utils::Expectation::Success, {1, 2, 3, 4, 5, 6, 7, 8, 9, 10},
|
|
5 * sizeof(uint32_t));
|
|
|
|
// In bounds, non-multiple of 4 offsets
|
|
TestIndirectOffsetDrawIndexed(utils::Expectation::Failure, {1, 2, 3, 4, 5, 6}, 1);
|
|
TestIndirectOffsetDrawIndexed(utils::Expectation::Failure, {1, 2, 3, 4, 5, 6}, 2);
|
|
|
|
// Out of bounds, buffer too small
|
|
TestIndirectOffsetDrawIndexed(utils::Expectation::Failure, {1, 2, 3, 4}, 0);
|
|
// Out of bounds, index too big
|
|
TestIndirectOffsetDrawIndexed(utils::Expectation::Failure, {1, 2, 3, 4, 5},
|
|
1 * sizeof(uint32_t));
|
|
// Out of bounds, index past buffer
|
|
TestIndirectOffsetDrawIndexed(utils::Expectation::Failure, {1, 2, 3, 4, 5},
|
|
5 * sizeof(uint32_t));
|
|
// Out of bounds, index + size of command overflows
|
|
uint64_t offset = std::numeric_limits<uint64_t>::max();
|
|
TestIndirectOffsetDrawIndexed(utils::Expectation::Failure, {1, 2, 3, 4, 5, 6, 7, 8, 9, 10},
|
|
offset);
|
|
}
|
|
|
|
// Check that the buffer must have the indirect usage
|
|
TEST_F(DrawIndirectValidationTest, IndirectUsage) {
|
|
// Control cases: using a buffer with the indirect usage is valid.
|
|
TestIndirectOffset(utils::Expectation::Success, {1, 2, 3, 4}, 0, false,
|
|
wgpu::BufferUsage::Indirect);
|
|
TestIndirectOffset(utils::Expectation::Success, {1, 2, 3, 4, 5}, 0, true,
|
|
wgpu::BufferUsage::Indirect);
|
|
|
|
// Error cases: using a buffer with the vertex usage is an error.
|
|
TestIndirectOffset(utils::Expectation::Failure, {1, 2, 3, 4}, 0, false,
|
|
wgpu::BufferUsage::Vertex);
|
|
TestIndirectOffset(utils::Expectation::Failure, {1, 2, 3, 4, 5}, 0, true,
|
|
wgpu::BufferUsage::Vertex);
|
|
}
|