mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-05-14 19:31:25 +00:00
Currently the presubmit will emit a warning if the formatting fails but this is easy to miss as the bot goes green. This CL changes the presubmit to make formatting an error so the issue will be caught and fixedup before landing. Change-Id: Ifb83d2a7e524fd086e86b47f7518fea1e65f6d3e Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/109563 Kokoro: Kokoro <noreply+kokoro@google.com> Reviewed-by: Austin Eng <enga@chromium.org> Commit-Queue: Dan Sinclair <dsinclair@chromium.org>
179 lines
6.0 KiB
Python
179 lines
6.0 KiB
Python
# Copyright 2022 The Dawn & Tint Authors
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import re
|
|
|
|
USE_PYTHON3 = True
|
|
|
|
NONINCLUSIVE_REGEXES = [
|
|
r"(?i)black[-_]?list",
|
|
r"(?i)white[-_]?list",
|
|
r"(?i)gr[ea]y[-_]?list",
|
|
r"(?i)(first class citizen)",
|
|
r"(?i)black[-_]?hat",
|
|
r"(?i)white[-_]?hat",
|
|
r"(?i)gr[ea]y[-_]?hat",
|
|
r"(?i)master",
|
|
r"(?i)slave",
|
|
r"(?i)\bhim\b",
|
|
r"(?i)\bhis\b",
|
|
r"(?i)\bshe\b",
|
|
r"(?i)\bher\b",
|
|
r"(?i)\bguys\b",
|
|
r"(?i)\bhers\b",
|
|
r"(?i)\bman\b",
|
|
r"(?i)\bwoman\b",
|
|
r"(?i)\she\s",
|
|
r"(?i)\she$",
|
|
r"(?i)^he\s",
|
|
r"(?i)^he$",
|
|
r"(?i)\she['|\u2019]d\s",
|
|
r"(?i)\she['|\u2019]d$",
|
|
r"(?i)^he['|\u2019]d\s",
|
|
r"(?i)^he['|\u2019]d$",
|
|
r"(?i)\she['|\u2019]s\s",
|
|
r"(?i)\she['|\u2019]s$",
|
|
r"(?i)^he['|\u2019]s\s",
|
|
r"(?i)^he['|\u2019]s$",
|
|
r"(?i)\she['|\u2019]ll\s",
|
|
r"(?i)\she['|\u2019]ll$",
|
|
r"(?i)^he['|\u2019]ll\s",
|
|
r"(?i)^he['|\u2019]ll$",
|
|
r"(?i)grandfather",
|
|
r"(?i)\bmitm\b",
|
|
r"(?i)\bcrazy\b",
|
|
r"(?i)\binsane\b",
|
|
r"(?i)\bblind\sto\b",
|
|
r"(?i)\bflying\sblind\b",
|
|
r"(?i)\bblind\seye\b",
|
|
r"(?i)\bcripple\b",
|
|
r"(?i)\bcrippled\b",
|
|
r"(?i)\bdumb\b",
|
|
r"(?i)\bdummy\b",
|
|
r"(?i)\bparanoid\b",
|
|
r"(?i)\bsane\b",
|
|
r"(?i)\bsanity\b",
|
|
r"(?i)red[-_]?line",
|
|
]
|
|
|
|
NONINCLUSIVE_REGEX_LIST = []
|
|
for reg in NONINCLUSIVE_REGEXES:
|
|
NONINCLUSIVE_REGEX_LIST.append(re.compile(reg))
|
|
|
|
LINT_FILTERS = []
|
|
|
|
|
|
def _CheckNonInclusiveLanguage(input_api, output_api, source_file_filter=None):
|
|
"""Checks the files for non-inclusive language."""
|
|
|
|
matches = []
|
|
for f in input_api.AffectedFiles(include_deletes=False,
|
|
file_filter=source_file_filter):
|
|
line_num = 0
|
|
for line in f.NewContents():
|
|
line_num += 1
|
|
for reg in NONINCLUSIVE_REGEX_LIST:
|
|
match = reg.search(line)
|
|
if match:
|
|
matches.append(
|
|
"{} ({}): found non-inclusive language: {}".format(
|
|
f.LocalPath(), line_num, match.group(0)))
|
|
|
|
if len(matches):
|
|
return [
|
|
output_api.PresubmitPromptWarning("Non-inclusive language found:",
|
|
items=matches)
|
|
]
|
|
|
|
return []
|
|
|
|
|
|
def _NonInclusiveFileFilter(file):
|
|
filter_list = [
|
|
"Doxyfile", # References to main pages
|
|
"PRESUBMIT.py", # Non-inclusive language check data
|
|
"PRESUBMIT.py.tint", # Non-inclusive language check data
|
|
"docs/dawn/debug_markers.md", # External URL
|
|
"docs/dawn/infra.md", # Infra settings
|
|
"docs/tint/spirv-input-output-variables.md", # External URL
|
|
"infra/config/global/generated/cr-buildbucket.cfg", # Infra settings
|
|
"infra/config/global/main.star", # Infra settings
|
|
"infra/kokoro/windows/build.bat", # External URL
|
|
"src/dawn/common/GPUInfo.cpp", # External URL
|
|
"src/dawn/native/metal/BackendMTL.mm", # OSX Constant
|
|
"src/dawn/native/vulkan/SamplerVk.cpp", # External URL
|
|
"src/dawn/native/vulkan/TextureVk.cpp", # External URL
|
|
"src/dawn/node/tools/src/cmd/run-cts/main.go", # Terminal type name
|
|
"src/dawn/samples/ComputeBoids.cpp", # External URL
|
|
"src/dawn/tests/end2end/DepthBiasTests.cpp", # External URL
|
|
"src/tint/transform/canonicalize_entry_point_io.cc", # External URL
|
|
"test/tint/samples/compute_boids.wgsl", # External URL
|
|
"third_party/khronos/KHR/khrplatform.h", # Third party file
|
|
"tools/roll-all", # Branch name
|
|
"tools/src/container/key.go", # External URL
|
|
"go.sum", # External URL
|
|
]
|
|
return file.LocalPath() not in filter_list
|
|
|
|
|
|
def _DoCommonChecks(input_api, output_api):
|
|
results = []
|
|
results.extend(
|
|
input_api.canned_checks.CheckChangedLUCIConfigs(input_api, output_api))
|
|
|
|
result_factory = output_api.PresubmitPromptWarning
|
|
if input_api.is_committing:
|
|
result_factory = output_api.PresubmitError
|
|
|
|
results.extend(
|
|
input_api.canned_checks.CheckPatchFormatted(
|
|
input_api,
|
|
output_api,
|
|
check_python=True,
|
|
result_factory=result_factory))
|
|
results.extend(
|
|
input_api.canned_checks.CheckChangeHasDescription(
|
|
input_api, output_api))
|
|
results.extend(
|
|
input_api.canned_checks.CheckGNFormatted(input_api, output_api))
|
|
results.extend(
|
|
input_api.canned_checks.CheckChangeHasNoCrAndHasOnlyOneEol(
|
|
input_api, output_api))
|
|
results.extend(
|
|
input_api.canned_checks.CheckChangeHasNoTabs(input_api, output_api))
|
|
results.extend(
|
|
input_api.canned_checks.CheckChangeTodoHasOwner(input_api, output_api))
|
|
results.extend(
|
|
input_api.canned_checks.CheckChangeHasNoStrayWhitespace(
|
|
input_api, output_api))
|
|
results.extend(
|
|
input_api.canned_checks.CheckDoNotSubmit(input_api, output_api))
|
|
# Note, the verbose_level here should match what is set in tools/lint so
|
|
# the same set of lint errors are reported on the CQ and Kokoro bots.
|
|
results.extend(
|
|
input_api.canned_checks.CheckChangeLintsClean(
|
|
input_api, output_api, lint_filters=LINT_FILTERS, verbose_level=1))
|
|
results.extend(
|
|
_CheckNonInclusiveLanguage(input_api, output_api,
|
|
_NonInclusiveFileFilter))
|
|
return results
|
|
|
|
|
|
def CheckChangeOnUpload(input_api, output_api):
|
|
return _DoCommonChecks(input_api, output_api)
|
|
|
|
|
|
def CheckChangeOnCommit(input_api, output_api):
|
|
return _DoCommonChecks(input_api, output_api)
|