Ben Clayton
fcda15ef67
Move storage_class validation from wgsl to resolver
...
We don't want the WGSL parser to have to maintain type lookups.
If the WGSL language is updated to allow module-scope variables to be declared in any order, then the single-pass approach is going to fail horribly.
Instead do the check in the Resovler.
With this change, the AST nodes actually contain the correctly declared storage class.
Fix up the SPIR-V reader to generate StorageClass::kNone for handle types.
Fix all tests.
Bug: tint:724
Change-Id: I102e30c9bbef32de40e123c2676ea9a281dee74d
Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/50306
Commit-Queue: Ben Clayton <bclayton@google.com>
Reviewed-by: Antonio Maiorano <amaiorano@google.com>
Reviewed-by: James Price <jrprice@google.com>
2021-05-10 18:01:51 +00:00
..
2021-04-20 15:04:21 +00:00
2021-04-22 15:34:13 +00:00
2021-04-22 15:34:13 +00:00
2021-03-09 11:11:17 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-04-23 18:21:34 +00:00
2021-04-30 19:58:49 +00:00
2021-04-30 19:58:49 +00:00
2021-04-15 17:47:23 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-04-15 17:47:23 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-20 15:04:21 +00:00
2021-04-15 17:47:23 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-30 17:14:19 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-05-05 09:09:41 +00:00
2021-05-05 09:09:41 +00:00
2021-05-05 09:09:41 +00:00
2021-04-15 17:47:23 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-28 13:50:43 +00:00
2021-04-28 13:50:43 +00:00
2021-04-28 13:50:43 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-03-10 11:41:49 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-30 17:14:19 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:57:34 +00:00
2021-04-16 19:57:34 +00:00
2021-04-15 17:47:23 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-15 17:47:23 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-28 13:50:43 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-13 23:27:27 +00:00
2021-04-13 23:27:27 +00:00
2021-03-10 11:41:49 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-03-11 17:39:32 +00:00
2021-04-13 23:27:27 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-03-10 11:41:49 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-15 17:47:23 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-19 22:54:43 +00:00
2021-04-26 14:55:25 +00:00
2021-04-26 14:55:25 +00:00
2021-04-26 14:55:25 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-03-10 11:41:49 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-28 13:50:43 +00:00
2021-04-28 13:50:43 +00:00
2021-04-28 13:50:43 +00:00
2021-05-05 09:09:41 +00:00
2021-05-05 09:09:41 +00:00
2021-05-05 09:09:41 +00:00
2021-04-30 17:14:19 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-04-15 18:20:03 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-15 17:47:23 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-28 13:50:43 +00:00
2021-04-28 13:50:43 +00:00
2021-04-28 13:50:43 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-05-10 18:01:51 +00:00
2021-05-05 16:19:22 +00:00
2021-04-28 13:50:43 +00:00
2021-04-28 13:50:43 +00:00
2021-04-30 17:14:19 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-15 17:47:23 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-04-15 17:47:23 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-05-05 10:23:11 +00:00
2021-04-15 17:47:23 +00:00
2021-05-05 09:09:41 +00:00
2021-05-05 09:09:41 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-04-30 19:58:49 +00:00
2021-04-30 19:58:49 +00:00
2021-04-16 19:07:51 +00:00
2021-04-19 22:51:23 +00:00
2021-04-30 17:14:19 +00:00
2021-04-30 17:14:19 +00:00
2021-04-30 17:14:19 +00:00
2020-03-02 15:47:43 -05:00
2021-04-09 16:51:38 +00:00
2021-04-20 15:04:21 +00:00
2021-04-26 14:19:55 +00:00
2021-04-26 14:19:55 +00:00
2021-04-15 17:47:23 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-20 15:04:21 +00:00
2021-04-26 14:19:55 +00:00
2021-04-26 14:19:55 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-04-28 13:50:43 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-28 13:50:43 +00:00
2021-04-28 13:50:43 +00:00
2021-04-28 13:50:43 +00:00
2021-03-09 11:11:17 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-13 23:27:27 +00:00
2021-04-13 23:27:27 +00:00
2021-05-10 18:01:51 +00:00
2021-05-10 18:01:51 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-03-09 11:11:17 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-23 22:11:14 +00:00
2021-03-15 10:43:11 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-03-09 11:11:17 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-03-15 10:43:11 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-05-05 09:09:41 +00:00
2021-05-05 09:09:41 +00:00
2021-05-05 09:09:41 +00:00
2021-04-30 19:58:49 +00:00
2021-05-06 16:03:33 +00:00
2021-04-30 19:58:49 +00:00
2021-04-28 13:50:43 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-04-09 16:51:38 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-05-05 09:09:41 +00:00
2021-05-05 09:09:41 +00:00
2021-05-05 09:09:41 +00:00
2021-04-28 13:39:53 +00:00
2021-04-23 15:41:34 +00:00
2021-05-05 10:26:51 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-04-28 13:50:43 +00:00
2021-04-28 13:50:43 +00:00
2021-04-28 13:50:43 +00:00
2021-04-15 17:47:23 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2020-03-02 15:47:43 -05:00
2021-04-09 16:51:38 +00:00
2021-04-15 17:47:23 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00
2021-05-05 09:09:41 +00:00
2021-05-05 09:09:41 +00:00
2021-05-05 09:09:41 +00:00
2021-04-22 14:24:43 +00:00
2021-04-26 14:19:55 +00:00
2021-04-26 14:19:55 +00:00
2021-04-20 15:04:21 +00:00
2021-04-20 15:04:21 +00:00
2021-03-09 11:11:17 +00:00
2021-04-16 19:07:51 +00:00
2021-04-16 19:07:51 +00:00