mirror of
https://github.com/encounter/dawn-cmake.git
synced 2025-05-14 19:31:25 +00:00
53069b283d
Real problem was that we relied on SymbolTable::New() to be called with the default arg of "tint_symbol", which isn't ergonomic when forwarding to this function from others, like TextGenerator::UniqueIdentifier(). Instead, make New() take emptry string by default, and make it use "tint_symbol" if input arg is empty string. Also made it so that SymbolTable::Register() must not take an empty string, so we now assert, rather than return an invalid symbol. Change-Id: I386ece318c86d1d399f1dd1557a95fecac01f7ec Reviewed-on: https://dawn-review.googlesource.com/c/tint/+/56461 Kokoro: Kokoro <noreply+kokoro@google.com> Commit-Queue: Antonio Maiorano <amaiorano@google.com> Reviewed-by: Ben Clayton <bclayton@google.com>
64 lines
1.8 KiB
C++
64 lines
1.8 KiB
C++
// Copyright 2020 The Tint Authors.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "src/symbol_table.h"
|
|
|
|
#include "gtest/gtest-spi.h"
|
|
|
|
namespace tint {
|
|
namespace {
|
|
|
|
using SymbolTableTest = testing::Test;
|
|
|
|
TEST_F(SymbolTableTest, GeneratesSymbolForName) {
|
|
auto program_id = ProgramID::New();
|
|
SymbolTable s{program_id};
|
|
EXPECT_EQ(Symbol(1, program_id), s.Register("name"));
|
|
EXPECT_EQ(Symbol(2, program_id), s.Register("another_name"));
|
|
}
|
|
|
|
TEST_F(SymbolTableTest, DeduplicatesNames) {
|
|
auto program_id = ProgramID::New();
|
|
SymbolTable s{program_id};
|
|
EXPECT_EQ(Symbol(1, program_id), s.Register("name"));
|
|
EXPECT_EQ(Symbol(2, program_id), s.Register("another_name"));
|
|
EXPECT_EQ(Symbol(1, program_id), s.Register("name"));
|
|
}
|
|
|
|
TEST_F(SymbolTableTest, ReturnsNameForSymbol) {
|
|
auto program_id = ProgramID::New();
|
|
SymbolTable s{program_id};
|
|
auto sym = s.Register("name");
|
|
EXPECT_EQ("name", s.NameFor(sym));
|
|
}
|
|
|
|
TEST_F(SymbolTableTest, ReturnsBlankForMissingSymbol) {
|
|
auto program_id = ProgramID::New();
|
|
SymbolTable s{program_id};
|
|
EXPECT_EQ("$2", s.NameFor(Symbol(2, program_id)));
|
|
}
|
|
|
|
TEST_F(SymbolTableTest, AssertsForBlankString) {
|
|
EXPECT_FATAL_FAILURE(
|
|
{
|
|
auto program_id = ProgramID::New();
|
|
SymbolTable s{program_id};
|
|
s.Register("");
|
|
},
|
|
"internal compiler error");
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace tint
|