encounter/decomp-toolkit
1
0
Fork 0
mirror of https://github.com/encounter/decomp-toolkit.git synced 2025-06-27 17:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Skip writing objects and ldscripts if unchanged

Browse Source 
Avoids unnecessary rebuilds with build systems like ninja & make that track mtime
This commit is contained in:
Luke Street 2023-11-18 17:21:08 -05:00
parent 363fa2ac72
commit 8659b56da4
1 changed files with 20 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/cmd/dol.rs
View File

@ -17,6 +17,7 @@ use itertools::Itertools;
use rayon::prelude::*; use rayon::prelude::*;
use serde::{Deserialize, Serialize}; use serde::{Deserialize, Serialize};
use tracing::{debug, info, info_span}; use tracing::{debug, info, info_span};
use xxhash_rust::xxh3::xxh3_64;
use crate::{ use crate::{
analysis::{ analysis::{
@ -830,8 +831,7 @@ fn split_write_obj(
if let Some(parent) = out_path.parent() { if let Some(parent) = out_path.parent() {
DirBuilder::new().recursive(true).create(parent)?; DirBuilder::new().recursive(true).create(parent)?;
} }
fs::write(&out_path, out_obj) write_if_changed(&out_path, &out_obj)?;
.with_context(|| format!("Failed to write '{}'", out_path.display()))?;
} }
// Generate ldscript.lcf // Generate ldscript.lcf
@ -842,10 +842,9 @@ fn split_write_obj(
} else { } else {
None None
}; };
fs::write( let ldscript_string =
&out_config.ldscript, generate_ldscript(&module.obj, ldscript_template.as_deref(), &module.config.force_active)?;
generate_ldscript(&module.obj, ldscript_template.as_deref(), &module.config.force_active)?, write_if_changed(&out_config.ldscript, ldscript_string.as_bytes())?;
)?;
if config.write_asm { if config.write_asm {
debug!("Writing disassembly"); debug!("Writing disassembly");
@ -862,6 +861,21 @@ fn split_write_obj(
Ok(out_config) Ok(out_config)
} }
fn write_if_changed(path: &Path, contents: &[u8]) -> Result<()> {
if path.is_file() {
let old_file = map_file(path)?;
// If the file is the same size, check if the contents are the same
// Avoid writing if unchanged, since it will update the file's mtime
if old_file.len() == contents.len() as u64
&& xxh3_64(old_file.as_slice()) == xxh3_64(contents)
{
return Ok(());
}
}
fs::write(path, contents)?;
Ok(())
}
fn load_analyze_rel(config: &ProjectConfig, module_config: &ModuleConfig) -> Result<AnalyzeResult> { fn load_analyze_rel(config: &ProjectConfig, module_config: &ModuleConfig) -> Result<AnalyzeResult> {
debug!("Loading {}", module_config.object.display()); debug!("Loading {}", module_config.object.display());
let file = map_file(&module_config.object)?; let file = map_file(&module_config.object)?;