encounter/objdiff
1
0
Fork 0
mirror of https://github.com/encounter/objdiff.git synced 2025-12-14 07:36:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Instruction hover / context menu improvements

Browse Source
This commit is contained in:
Luke Street
2024-05-20 17:38:20 -06:00
parent 8b36fa4fc6
commit 5bfaaaaf65
10 changed files with 68 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
objdiff-core/src/arch/x86.rs
View File

@@ -57,6 +57,7 @@ impl ObjArch for ObjArchX86 {
reloc: None,
branch_dest: None,
line: None,
formatted: String::new(),
orig: None,
},
error: None,
@@ -81,6 +82,7 @@ impl ObjArch for ObjArchX86 {
reloc: reloc.cloned(),
branch_dest: None,
line: obj.line_info.as_ref().and_then(|m| m.get(&address).cloned()),
formatted: String::new(),
orig: None,
};
// Run the formatter, which will populate output.ins
@@ -89,7 +91,7 @@ impl ObjArch for ObjArchX86 {
return Err(error);
}
ensure!(output.ins_operands.len() == output.ins.args.len());
output.ins.orig = Some(output.formatted.clone());
output.ins.formatted.clone_from(&output.formatted);
// Make sure we've put the relocation somewhere in the instruction
if reloc.is_some() && !output.ins.args.iter().any(|a| matches!(a, ObjInsArg::Reloc)) {