encounter/objdiff
1
0
Fork 0
mirror of https://github.com/encounter/objdiff.git synced 2025-06-07 07:03:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

PPC: Fix pooled relocation addends being added twice sometimes (#184)

Browse Source
This commit is contained in:
LagoLunatic 2025-03-31 00:00:36 -04:00 committed by GitHub
parent e101610416
commit b9ba5796ed
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
objdiff-core/src/arch/ppc.rs
View File

@ -513,6 +513,7 @@ fn guess_data_type_from_load_store_inst_op(inst_op: ppc750cl::Opcode) -> Option<
} }
} }
#[derive(Debug)]
struct PoolReference { struct PoolReference {
addr_src_gpr: ppc750cl::GPR, addr_src_gpr: ppc750cl::GPR,
addr_offset: i16, addr_offset: i16,
@ -645,7 +646,7 @@ fn make_fake_pool_reloc(
// example, dCcD_Cyl in The Wind Waker). So just showing that vtable symbol plus an addend // example, dCcD_Cyl in The Wind Waker). So just showing that vtable symbol plus an addend
// to represent the offset into it works fine in this case. // to represent the offset into it works fine in this case.
target_symbol = pool_reloc.relocation.target_symbol; target_symbol = pool_reloc.relocation.target_symbol;
addend = pool_reloc.relocation.addend + offset_from_pool; addend = offset_from_pool;
} }
Some(Relocation { Some(Relocation {
flags: RelocationFlags::Elf(elf::R_PPC_NONE), flags: RelocationFlags::Elf(elf::R_PPC_NONE),