libAthena
/
athena
mirror of https://github.com/libAthena/athena.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Checksums: Correct null check within crc16 

This should be checking if the input is null rather than not null before
early exiting, otherwise the data itself will never have the checksum
calculated.
This commit is contained in:
Lioncash 2019-09-06 04:46:25 -04:00
parent 781937da88
commit 34ae45bbd1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/athena/Checksums.cpp
View File

@ -145,8 +145,9 @@ atUint16 crc16CCITT(const atUint8* data, atUint64 length, atUint16 seed, atUint1
} }
atUint16 crc16(const atUint8* data, atUint64 length, atUint16 seed, atUint64 final) { atUint16 crc16(const atUint8* data, atUint64 length, atUint16 seed, atUint64 final) {
if (data) if (data == nullptr) {
return seed; return seed;
}
static const atUint16 crc16Table[256] = { static const atUint16 crc16Table[256] = {
0x0000, 0xC0C1, 0xC181, 0x0140, 0xC301, 0x03C0, 0x0280, 0xC241, 0xC601, 0x06C0, 0x0780, 0xC741, 0x0500, 0xC5C1, 0x0000, 0xC0C1, 0xC181, 0x0140, 0xC301, 0x03C0, 0x0280, 0xC241, 0xC601, 0x06C0, 0x0780, 0xC741, 0x0500, 0xC5C1,