libAthena
/
athena
mirror of https://github.com/libAthena/athena.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Proper pure-virtual convention

This commit is contained in:
Jack Andersen 2017-01-25 22:07:48 -10:00
parent dd8b60f779
commit a1acdac588
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/athena/DNA.hpp
View File

@ -44,7 +44,7 @@ struct WStringAsString;
template <Endian DNAE> template <Endian DNAE>
struct DNA struct DNA
{ {
virtual ~DNA() {} virtual ~DNA() = default;
/** /**
* @brief Common virtual read function for all DNA types * @brief Common virtual read function for all DNA types

10
include/athena/DNAYaml.hpp
View File

@ -1203,14 +1203,14 @@ struct WStringAsStringYaml;
template <Endian DNAE> template <Endian DNAE>
struct DNAYaml : DNA<DNAE> struct DNAYaml : DNA<DNAE>
{ {
virtual ~DNAYaml() {} virtual ~DNAYaml() = default;
using DNA<DNAE>::read; virtual void read(IStreamReader& r)=0;
using DNA<DNAE>::write; virtual void write(IStreamWriter& w) const=0;
virtual void read(YAMLDocReader& in)=0; virtual void read(YAMLDocReader& in)=0;
virtual void write(YAMLDocWriter& out) const=0; virtual void write(YAMLDocWriter& out) const=0;
static const char* DNAType() {return nullptr;} static const char* DNAType() { return nullptr; }
virtual const char* DNATypeV() const {return nullptr;} virtual const char* DNATypeV() const { return nullptr; }
template <size_t sizeVar> template <size_t sizeVar>
using Buffer = struct athena::io::BufferYaml<sizeVar, DNAE>; using Buffer = struct athena::io::BufferYaml<sizeVar, DNAE>;