AxioDL/PrimeWorldEditor
2
0
Fork 0
mirror of https://github.com/AxioDL/PrimeWorldEditor.git synced 2025-07-05 12:45:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

CPackage: std::move strings in constructor where applicable

Browse Source 
Allows calling code to completely avoid copies.
This commit is contained in:
Lioncash 2020-06-18 18:46:35 -04:00
parent bf9be7f2ad
commit 36e005844f
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Core/GameProject/CGameProject.cpp
View File

@ -62,7 +62,7 @@ bool CGameProject::Serialize(IArchive& rArc)
TString PackageName = packagePath.GetFileName(false); TString PackageName = packagePath.GetFileName(false);
TString PackageDir = packagePath.GetFileDirectory(); TString PackageDir = packagePath.GetFileDirectory();
auto pPackage = std::make_unique<CPackage>(this, PackageName, PackageDir); auto pPackage = std::make_unique<CPackage>(this, std::move(PackageName), std::move(PackageDir));
const bool PackageLoadSuccess = pPackage->Load(); const bool PackageLoadSuccess = pPackage->Load();
mPackages.push_back(std::move(pPackage)); mPackages.push_back(std::move(pPackage));

6
src/Core/GameProject/CPackage.h
View File

@ -46,10 +46,10 @@ class CPackage
public: public:
CPackage() = default; CPackage() = default;
CPackage(CGameProject *pProj, const TString& rkName, const TString& rkPath) CPackage(CGameProject *pProj, TString rkName, TString rkPath)
: mpProject(pProj) : mpProject(pProj)
, mPakName(rkName) , mPakName(std::move(rkName))
, mPakPath(rkPath) , mPakPath(std::move(rkPath))
, mCacheDirty(true) , mCacheDirty(true)
{} {}