CResourceTableModel: Get rid of unnecessary parameter copies

This commit is contained in:
Lioncache
2025-12-03 17:06:56 -05:00
parent 478060ce75
commit 379fd472ed
2 changed files with 4 additions and 4 deletions

View File

@@ -342,7 +342,7 @@ void CResourceTableModel::CheckRemoveDirectory(CVirtualDirectory *pDir)
endRemoveRows(); endRemoveRows();
} }
void CResourceTableModel::OnResourceMoved(CResourceEntry *pEntry, CVirtualDirectory *pOldDir, TString OldName) void CResourceTableModel::OnResourceMoved(CResourceEntry *pEntry, CVirtualDirectory *pOldDir, const TString& OldName)
{ {
CVirtualDirectory *pNewDir = pEntry->Directory(); CVirtualDirectory *pNewDir = pEntry->Directory();
const bool WasInModel = (pOldDir == mpCurrentDir || (mIsAssetListMode && pOldDir->IsDescendantOf(mpCurrentDir))); const bool WasInModel = (pOldDir == mpCurrentDir || (mIsAssetListMode && pOldDir->IsDescendantOf(mpCurrentDir)));
@@ -381,7 +381,7 @@ void CResourceTableModel::OnResourceMoved(CResourceEntry *pEntry, CVirtualDirect
} }
} }
void CResourceTableModel::OnDirectoryMoved(CVirtualDirectory *pDir, CVirtualDirectory *pOldDir, TString OldName) void CResourceTableModel::OnDirectoryMoved(CVirtualDirectory *pDir, CVirtualDirectory *pOldDir, const TString& OldName)
{ {
CVirtualDirectory *pNewDir = pDir->Parent(); CVirtualDirectory *pNewDir = pDir->Parent();
const bool WasInModel = !mIsAssetListMode && pOldDir == mpCurrentDir; const bool WasInModel = !mIsAssetListMode && pOldDir == mpCurrentDir;

View File

@@ -63,8 +63,8 @@ public slots:
void CheckRemoveResource(CResourceEntry *pEntry); void CheckRemoveResource(CResourceEntry *pEntry);
void CheckAddDirectory(CVirtualDirectory *pDir); void CheckAddDirectory(CVirtualDirectory *pDir);
void CheckRemoveDirectory(CVirtualDirectory *pDir); void CheckRemoveDirectory(CVirtualDirectory *pDir);
void OnResourceMoved(CResourceEntry *pEntry, CVirtualDirectory *pOldDir, TString OldName); void OnResourceMoved(CResourceEntry *pEntry, CVirtualDirectory *pOldDir, const TString& OldName);
void OnDirectoryMoved(CVirtualDirectory *pDir, CVirtualDirectory *pOldDir, TString OldName); void OnDirectoryMoved(CVirtualDirectory *pDir, CVirtualDirectory *pOldDir, const TString& OldName);
}; };
#endif // CRESOURCELISTMODEL #endif // CRESOURCELISTMODEL