AxioDL/PrimeWorldEditor
2
0
Fork 0
mirror of https://github.com/AxioDL/PrimeWorldEditor.git synced 2025-07-10 15:15:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

CTweakEditor: Make use of in-class initializers where applicable

Browse Source
This commit is contained in:
Lioncash 2020-06-28 06:12:06 -04:00
parent 2cf3ac718b
commit 43250fb5ce
2 changed files with 16 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/Editor/CTweakEditor.cpp
View File

@ -16,17 +16,15 @@ public:
, mNewIndex(NewIndex) , mNewIndex(NewIndex)
{} {}
virtual void undo() override { mpEditor->SetActiveTweakIndex(mOldIndex); } void undo() override { mpEditor->SetActiveTweakIndex(mOldIndex); }
virtual void redo() override { mpEditor->SetActiveTweakIndex(mNewIndex); } void redo() override { mpEditor->SetActiveTweakIndex(mNewIndex); }
virtual bool AffectsCleanState() const override { return false; } bool AffectsCleanState() const override { return false; }
}; };
/** CTweakEditor functions */ /** CTweakEditor functions */
CTweakEditor::CTweakEditor(QWidget* pParent) CTweakEditor::CTweakEditor(QWidget* pParent)
: IEditor(pParent) : IEditor(pParent)
, mpUI(new Ui::CTweakEditor) , mpUI(std::make_unique<Ui::CTweakEditor>())
, mCurrentTweakIndex(-1)
, mHasBeenShown(false)
{ {
mpUI->setupUi(this); mpUI->setupUi(this);
mpUI->TweakTabs->setExpanding(false); mpUI->TweakTabs->setExpanding(false);
@ -39,12 +37,9 @@ CTweakEditor::CTweakEditor(QWidget* pParent)
connect(mpUI->ActionSaveAndRepack, SIGNAL(triggered(bool)), this, SLOT(SaveAndRepack())); connect(mpUI->ActionSaveAndRepack, SIGNAL(triggered(bool)), this, SLOT(SaveAndRepack()));
} }
CTweakEditor::~CTweakEditor() CTweakEditor::~CTweakEditor() = default;
{
delete mpUI;
}
bool CTweakEditor::HasTweaks() bool CTweakEditor::HasTweaks() const
{ {
return !mTweakAssets.isEmpty(); return !mTweakAssets.isEmpty();
} }

17
src/Editor/CTweakEditor.h
View File

@ -2,6 +2,9 @@
#define CTWEAKEDITOR_H #define CTWEAKEDITOR_H
#include "Editor/IEditor.h" #include "Editor/IEditor.h"
#include "Tweaks/CTweakData.h"
#include <memory>
namespace Ui { namespace Ui {
class CTweakEditor; class CTweakEditor;
@ -12,23 +15,23 @@ class CTweakEditor : public IEditor
Q_OBJECT Q_OBJECT
/** Qt UI */ /** Qt UI */
Ui::CTweakEditor* mpUI; std::unique_ptr<Ui::CTweakEditor> mpUI;
/** List of editable tweak assets */ /** List of editable tweak assets */
QVector<CTweakData*> mTweakAssets; QVector<CTweakData*> mTweakAssets;
/** Whether the editor window has been shown before */ /** Whether the editor window has been shown before */
bool mHasBeenShown; bool mHasBeenShown = false;
/** Index of tweak data currently being edited */ /** Index of tweak data currently being edited */
int mCurrentTweakIndex; int mCurrentTweakIndex = -1;
public: public:
explicit CTweakEditor(QWidget* pParent = 0); explicit CTweakEditor(QWidget* pParent = nullptr);
~CTweakEditor(); ~CTweakEditor() override;
bool HasTweaks();
virtual bool Save() override; bool HasTweaks() const;
bool Save() override;
public slots: public slots:
void SetActiveTweakData(CTweakData* pTweakData); void SetActiveTweakData(CTweakData* pTweakData);