Editor: Mark remaining undo command strings as translatable

Ensures that we're marking the remnant potential display strings properly.
2025-12-08 21:17:53 +00:00 · 2025-12-01 14:34:33 -05:00
parent db7e832f32
commit 5fc6b50923
27 changed files with 84 additions and 32 deletions
--- a/src/Editor/Undo/CAddLinkCommand.cpp
+++ b/src/Editor/Undo/CAddLinkCommand.cpp
@@ -1,8 +1,10 @@
 #include "CAddLinkCommand.h"
 #include <Core/Resource/Script/CLink.h>

+#include <QCoreApplication>
+
 CAddLinkCommand::CAddLinkCommand(CWorldEditor *pEditor, CLink Link)
-    : IUndoCommand("Add Link")
+    : IUndoCommand(QCoreApplication::translate("CAddLinkCommand", "Add Link"))
    , mpEditor(pEditor)
    , mLink(Link)
 {
--- a/src/Editor/Undo/CChangeLayerCommand.cpp
+++ b/src/Editor/Undo/CChangeLayerCommand.cpp
@@ -1,7 +1,9 @@
 #include "CChangeLayerCommand.h"

+#include <QCoreApplication>
+
 CChangeLayerCommand::CChangeLayerCommand(CWorldEditor *pEditor, const QList<CScriptNode*>& rkNodeList, CScriptLayer *pNewLayer)
-    : IUndoCommand("Change Layer")
+    : IUndoCommand(QCoreApplication::translate("CChangeLayerCommand", "Change Layer"))
    , mpNewLayer(pNewLayer)
    , mpEditor(pEditor)
 {
--- a/src/Editor/Undo/CClearSelectionCommand.h
+++ b/src/Editor/Undo/CClearSelectionCommand.h
@@ -7,6 +7,8 @@
 #include "Editor/INodeEditor.h"
 #include <Core/Scene/CSceneNode.h>

+#include <QCoreApplication>
+
 class CClearSelectionCommand : public IUndoCommand
 {
    CNodeSelection *mpSelection;
@@ -14,7 +16,7 @@ class CClearSelectionCommand : public IUndoCommand

 public:
    explicit CClearSelectionCommand(CNodeSelection *pSelection)
-        : IUndoCommand("Clear Selection"),
+        : IUndoCommand(QCoreApplication::translate("CClearSelectionCommand", "Clear Selection")),
          mpSelection(pSelection)
    {
        for (CSelectionIterator It(pSelection); It; ++It)
--- a/src/Editor/Undo/CCloneSelectionCommand.cpp
+++ b/src/Editor/Undo/CCloneSelectionCommand.cpp
@@ -1,8 +1,10 @@
 #include "CCloneSelectionCommand.h"
 #include "Editor/CSelectionIterator.h"

+#include <QCoreApplication>
+
 CCloneSelectionCommand::CCloneSelectionCommand(INodeEditor *pEditor)
-    : IUndoCommand("Clone")
+    : IUndoCommand(QCoreApplication::translate("CCloneSelectionCommand", "Clone"))
    , mpEditor(qobject_cast<CWorldEditor*>(pEditor)) // todo: fix this! bad assumption! (clone handling code is in INodeEditor but active area is in CWorldEditor)
 {
    mOriginalSelection = mpEditor->Selection()->SelectedNodeList();
--- a/src/Editor/Undo/CCreateInstanceCommand.cpp
+++ b/src/Editor/Undo/CCreateInstanceCommand.cpp
@@ -1,7 +1,9 @@
 #include "CCreateInstanceCommand.h"

+#include <QCoreApplication>
+
 CCreateInstanceCommand::CCreateInstanceCommand(CWorldEditor *pEditor, CScriptTemplate *pTemplate, CScriptLayer *pLayer, const CVector3f& rkPosition)
-    : IUndoCommand("Create Instance")
+    : IUndoCommand(QCoreApplication::translate("CCreateInstanceCommand", "Create Instance"))
    , mpEditor(pEditor)
    , mpScene(pEditor->Scene())
    , mpArea(pEditor->ActiveArea())
--- a/src/Editor/Undo/CDeleteLinksCommand.cpp
+++ b/src/Editor/Undo/CDeleteLinksCommand.cpp
@@ -1,8 +1,10 @@
 #include "CDeleteLinksCommand.h"
 #include <Core/Resource/Script/CLink.h>

+#include <QCoreApplication>
+
 CDeleteLinksCommand::CDeleteLinksCommand(CWorldEditor *pEditor, CScriptObject *pObject, ELinkType Type, const QList<uint32>& rkIndices)
-    : IUndoCommand("Delete Links")
+    : IUndoCommand(QCoreApplication::translate("CDeleteLinksCommand", "Delete Links"))
    , mpEditor(pEditor)
 {
    mAffectedInstances.push_back(pObject);
--- a/src/Editor/Undo/CDeleteSelectionCommand.h
+++ b/src/Editor/Undo/CDeleteSelectionCommand.h
@@ -7,6 +7,8 @@
 #include "Editor/WorldEditor/CWorldEditor.h"
 #include <Core/Scene/CSceneNode.h>

+#include <QCoreApplication>
+
 // todo: currently only supports deleting script nodes; needs support for light nodes as well
 // plus maybe it should be extensible enough to support other possible types
 class CDeleteSelectionCommand : public IUndoCommand
@@ -47,7 +49,7 @@ class CDeleteSelectionCommand : public IUndoCommand
    QList<SDeletedLink> mDeletedLinks;

 public:
-    explicit CDeleteSelectionCommand(CWorldEditor *pEditor, const QString& rkCommandName = "Delete");
+    explicit CDeleteSelectionCommand(CWorldEditor *pEditor, const QString& rkCommandName = QCoreApplication::translate("CDeleteSelectionCommand", "Delete"));
    void undo() override;
    void redo() override;
    bool AffectsCleanState() const override { return true; }
--- a/src/Editor/Undo/CDeselectNodeCommand.h
+++ b/src/Editor/Undo/CDeselectNodeCommand.h
@@ -6,13 +6,15 @@
 #include "Editor/INodeEditor.h"
 #include <Core/Scene/CSceneNode.h>

+#include <QCoreApplication>
+
 class CDeselectNodeCommand : public IUndoCommand
 {
    CNodePtr mpNode;
    CNodeSelection *mpSelection;
 public:
    CDeselectNodeCommand(CNodeSelection *pSelection, CSceneNode *pNode)
-        : IUndoCommand("Deselect")
+        : IUndoCommand(QCoreApplication::translate("CDeselectNodeCommand", "Deselect"))
        , mpNode(pNode)
        , mpSelection(pSelection)
    {}
--- a/src/Editor/Undo/CEditIntrinsicPropertyCommand.h
+++ b/src/Editor/Undo/CEditIntrinsicPropertyCommand.h
@@ -2,6 +2,7 @@
 #define CEDITINTRINSICPROPERTYCOMMAND_H

 #include "IEditPropertyCommand.h"
+#include <QCoreApplication>

 class CEditIntrinsicPropertyCommand : public IEditPropertyCommand
 {
@@ -13,7 +14,7 @@ public:
                                  const QList<void*>& kDataPointers,
                                  CPropertyModel* pModel,
                                  QModelIndex Index = QModelIndex(),
-                                  const QString& kCommandName = "Edit Property")
+                                  const QString& kCommandName = QCoreApplication::translate("CEditIntrinsicPropertyCommand", "Edit Property"))
        : IEditPropertyCommand(pProperty, pModel, Index, kCommandName)
        , mDataPointers(kDataPointers)
    {
--- a/src/Editor/Undo/CEditLinkCommand.cpp
+++ b/src/Editor/Undo/CEditLinkCommand.cpp
@@ -1,7 +1,9 @@
 #include "CEditLinkCommand.h"

+#include <QCoreApplication>
+
 CEditLinkCommand::CEditLinkCommand(CWorldEditor *pEditor, CLink *pLink, CLink NewLink)
-    : IUndoCommand("Edit Link")
+    : IUndoCommand(QCoreApplication::translate("CEditLinkCommand", "Edit Link"))
    , mpEditor(pEditor)
    , mpEditLink(pLink)
    , mOldLink(*pLink)
--- a/src/Editor/Undo/CEditScriptPropertyCommand.h
+++ b/src/Editor/Undo/CEditScriptPropertyCommand.h
@@ -5,6 +5,8 @@
 #include "ObjReferences.h"
 #include "Editor/WorldEditor/CWorldEditor.h"

+#include <QCoreApplication>
+
 class CEditScriptPropertyCommand : public IEditPropertyCommand
 {
 protected:
@@ -16,7 +18,7 @@ public:
                               const QList<CScriptObject*>& kInstances,
                               CPropertyModel* pModel,
                               QModelIndex Index = QModelIndex(),
-                               const QString& kCommandName = "Edit Property")
+                               const QString& kCommandName = QCoreApplication::translate("CEditScriptPropertyCommand", "Edit Property"))
        : IEditPropertyCommand(pProperty, pModel, Index, kCommandName)
        , mIndex(Index)
    {
--- a/src/Editor/Undo/CInvertSelectionCommand.h
+++ b/src/Editor/Undo/CInvertSelectionCommand.h
@@ -6,6 +6,8 @@
 #include "Editor/INodeEditor.h"
 #include <Core/Scene/CSceneNode.h>

+#include <QCoreApplication>
+
 class CInvertSelectionCommand : public IUndoCommand
 {
    CNodeSelection *mpSelection;
@@ -14,7 +16,7 @@ class CInvertSelectionCommand : public IUndoCommand

 public:
    CInvertSelectionCommand(CNodeSelection *pSelection, CScene *pScene, FNodeFlags NodeFlags)
-        : IUndoCommand("Invert Selection")
+        : IUndoCommand(QCoreApplication::translate("CInvertSelectionCommand", "Invert Selection"))
        , mpSelection(pSelection)
    {
        for (CSceneIterator It(pScene, NodeFlags); It; ++It)
--- a/src/Editor/Undo/CMoveDirectoryCommand.h
+++ b/src/Editor/Undo/CMoveDirectoryCommand.h
@@ -7,6 +7,8 @@
 #include <Core/GameProject/CResourceStore.h>
 #include <Core/GameProject/CVirtualDirectory.h>

+#include <QCoreApplication>
+
 class CMoveDirectoryCommand : public IUndoCommand
 {
    CResourceStore *mpStore;
@@ -16,7 +18,7 @@ class CMoveDirectoryCommand : public IUndoCommand

 public:
    CMoveDirectoryCommand(CResourceStore *pStore, CVirtualDirectory *pDir, CVirtualDirectory *pNewParent)
-        : IUndoCommand("Move Directory")
+        : IUndoCommand(QCoreApplication::translate("CMoveDirectoryCommand", "Move Directory"))
        , mpStore(pStore)
        , mTargetDir(pDir->FullPath())
        , mOldParent(pDir->Parent()->FullPath())
--- a/src/Editor/Undo/CMoveResourceCommand.h
+++ b/src/Editor/Undo/CMoveResourceCommand.h
@@ -6,6 +6,8 @@
 #include "Editor/ResourceBrowser/CResourceBrowser.h"
 #include <Core/GameProject/CResourceEntry.h>

+#include <QCoreApplication>
+
 class CMoveResourceCommand : public IUndoCommand
 {
    CResourceEntry *mpEntry;
@@ -15,7 +17,7 @@ class CMoveResourceCommand : public IUndoCommand

 public:
    CMoveResourceCommand(CResourceEntry *pEntry, CVirtualDirectory *pNewDir)
-        : IUndoCommand("Move Resource")
+        : IUndoCommand(QCoreApplication::translate("CMoveResourceCommand", "Move Resource"))
        , mpEntry(pEntry)
        , mOldDirPath(pEntry->DirectoryPath())
        , mNewDirPath(pNewDir->FullPath())
--- a/src/Editor/Undo/CPasteNodesCommand.cpp
+++ b/src/Editor/Undo/CPasteNodesCommand.cpp
@@ -1,7 +1,9 @@
 #include "CPasteNodesCommand.h"

+#include <QCoreApplication>
+
 CPasteNodesCommand::CPasteNodesCommand(CWorldEditor *pEditor, CScriptLayer *pLayer, CVector3f PastePoint)
-    : IUndoCommand("Paste")
+    : IUndoCommand(QCoreApplication::translate("CPasteNodesCommand", "Paste"))
    , mpEditor(pEditor)
    , mpLayer(pLayer)
    , mPastePoint(PastePoint)
--- a/src/Editor/Undo/CRenameDirectoryCommand.h
+++ b/src/Editor/Undo/CRenameDirectoryCommand.h
@@ -6,6 +6,8 @@
 #include "Editor/ResourceBrowser/CResourceBrowser.h"
 #include <Core/GameProject/CVirtualDirectory.h>

+#include <QCoreApplication>
+
 class CRenameDirectoryCommand : public IUndoCommand
 {
    CVirtualDirectory *mpDir;
@@ -14,7 +16,7 @@ class CRenameDirectoryCommand : public IUndoCommand

 public:
    CRenameDirectoryCommand(CVirtualDirectory *pDir, const TString& rkNewName)
-        : IUndoCommand("Rename Directory")
+        : IUndoCommand(QCoreApplication::translate("CRenameDirectoryCommand", "Rename Directory"))
        , mpDir(pDir)
        , mOldName(pDir->Name())
        , mNewName(rkNewName)
--- a/src/Editor/Undo/CRenameResourceCommand.h
+++ b/src/Editor/Undo/CRenameResourceCommand.h
@@ -6,6 +6,8 @@
 #include "Editor/ResourceBrowser/CResourceBrowser.h"
 #include <Core/GameProject/CResourceEntry.h>

+#include <QCoreApplication>
+
 class CRenameResourceCommand : public IUndoCommand
 {
    CResourceEntry *mpEntry;
@@ -15,7 +17,7 @@ class CRenameResourceCommand : public IUndoCommand

 public:
    CRenameResourceCommand(CResourceEntry *pEntry, const TString& rkNewName)
-        : IUndoCommand("Rename Resource")
+        : IUndoCommand(QCoreApplication::translate("CRenameResourceCommand", "Rename Resource"))
        , mpEntry(pEntry)
        , mOldName(pEntry->Name())
        , mNewName(rkNewName)
--- a/src/Editor/Undo/CResizeScriptArrayCommand.h
+++ b/src/Editor/Undo/CResizeScriptArrayCommand.h
@@ -2,6 +2,7 @@
 #define CRESIZESCRIPTARRAYCOMMAND_H

 #include "CEditScriptPropertyCommand.h"
+#include <QCoreApplication>

 class CResizeScriptArrayCommand : public CEditScriptPropertyCommand
 {
@@ -14,7 +15,7 @@ public:
                              const QList<CScriptObject*>& rkInstances,
                              CPropertyModel* pModel,
                              QModelIndex Index = QModelIndex(),
-                              const QString& rkCommandName = "Resize Array"
+                              const QString& rkCommandName = QCoreApplication::translate("CResizeScriptArrayCommand", "Resize Array")
                )
        :   CEditScriptPropertyCommand(pProperty, rkInstances, pModel, Index, rkCommandName)
    {
--- a/src/Editor/Undo/CRotateNodeCommand.cpp
+++ b/src/Editor/Undo/CRotateNodeCommand.cpp
@@ -2,8 +2,10 @@
 #include "EUndoCommand.h"
 #include "Editor/INodeEditor.h"

+#include <QCoreApplication>
+
 CRotateNodeCommand::CRotateNodeCommand()
-    : IUndoCommand("Rotate")
+    : IUndoCommand(QCoreApplication::translate("CRotateNodeCommand", "Rotate"))
 {
 }

@@ -16,7 +18,7 @@ CRotateNodeCommand::CRotateNodeCommand(
        const CQuaternion& rkDelta,
        ETransformSpace TransformSpace
    )
-    : IUndoCommand("Rotate"),
+    : IUndoCommand(QCoreApplication::translate("CRotateNodeCommand", "Rotate")),
      mpEditor(pEditor)
 {
    mNodeList.reserve(rkNodes.size());
--- a/src/Editor/Undo/CSaveStoreCommand.h
+++ b/src/Editor/Undo/CSaveStoreCommand.h
@@ -4,6 +4,8 @@
 #include "IUndoCommand.h"
 #include <Core/GameProject/CResourceStore.h>

+#include <QCoreApplication>
+
 /** Command that calls ConditionalSaveStore on a resource store.
 *  This is meant to be added to undo macros that modify the resource store
 *  in order to trigger the store to resave when the macro is complete.
@@ -14,7 +16,7 @@ class CSaveStoreCommand : public IUndoCommand

 public:
    explicit CSaveStoreCommand(CResourceStore* pInStore)
-        : IUndoCommand("Save Store")
+        : IUndoCommand(QCoreApplication::translate("CSaveStoreCommand", "Save Store"))
        , mpStore(pInStore)
    {}

--- a/src/Editor/Undo/CScaleNodeCommand.cpp
+++ b/src/Editor/Undo/CScaleNodeCommand.cpp
@@ -2,13 +2,15 @@
 #include "EUndoCommand.h"
 #include "Editor/INodeEditor.h"

+#include <QCoreApplication>
+
 CScaleNodeCommand::CScaleNodeCommand()
-    : IUndoCommand("Scale")
+    : IUndoCommand(QCoreApplication::translate("CScaleNodeCommand", "Scale"))
 {
 }

 CScaleNodeCommand::CScaleNodeCommand(INodeEditor *pEditor, const QList<CSceneNode*>& rkNodes, bool UsePivot, const CVector3f& rkPivot, const CVector3f& rkDelta)
-    : IUndoCommand("Scale"),
+    : IUndoCommand(QCoreApplication::translate("CScaleNodeCommand", "Scale")),
      mpEditor(pEditor)
 {
    mNodeList.reserve(rkNodes.size());
--- a/src/Editor/Undo/CSelectAllCommand.h
+++ b/src/Editor/Undo/CSelectAllCommand.h
@@ -7,6 +7,8 @@
 #include "Editor/INodeEditor.h"
 #include <Core/Scene/CSceneNode.h>

+#include <QCoreApplication>
+
 class CSelectAllCommand : public IUndoCommand
 {
    CNodePtrList mOldSelection;
@@ -15,7 +17,7 @@ class CSelectAllCommand : public IUndoCommand

 public:
    CSelectAllCommand(CNodeSelection *pSelection, CScene *pScene, FNodeFlags NodeFlags)
-        : IUndoCommand("Select All")
+        : IUndoCommand(QCoreApplication::translate("CSelectAllCommand", "Select All"))
        , mpSelection(pSelection)
    {
        for (CSelectionIterator It(pSelection); It; ++It)
--- a/src/Editor/Undo/CSelectNodeCommand.h
+++ b/src/Editor/Undo/CSelectNodeCommand.h
@@ -6,6 +6,8 @@
 #include "Editor/INodeEditor.h"
 #include <Core/Scene/CSceneNode.h>

+#include <QCoreApplication>
+
 class CSelectNodeCommand : public IUndoCommand
 {
    CNodePtr mpNode;
@@ -13,7 +15,7 @@ class CSelectNodeCommand : public IUndoCommand

 public:
    CSelectNodeCommand(CNodeSelection *pSelection, CSceneNode *pNode)
-        : IUndoCommand("Select")
+        : IUndoCommand(QCoreApplication::translate("CSelectNodeCommand", "Select"))
        , mpNode(pNode)
        , mpSelection(pSelection)
    {}
--- a/src/Editor/Undo/CTranslateNodeCommand.cpp
+++ b/src/Editor/Undo/CTranslateNodeCommand.cpp
@@ -2,13 +2,15 @@
 #include "EUndoCommand.h"
 #include "Editor/INodeEditor.h"

+#include <QCoreApplication>
+
 CTranslateNodeCommand::CTranslateNodeCommand()
-    : IUndoCommand("Translate")
+    : IUndoCommand(QCoreApplication::translate("CTranslateNodeCommand", "Translate"))
 {
 }

 CTranslateNodeCommand::CTranslateNodeCommand(INodeEditor *pEditor, const QList<CSceneNode*>& rkNodes, const CVector3f& Delta, ETransformSpace TransformSpace)
-    : IUndoCommand("Translate"),
+    : IUndoCommand(QCoreApplication::translate("CTranslateNodeCommand", "Translate")),
      mpEditor(pEditor)
 {
    mNodeList.reserve(rkNodes.size());
--- a/src/Editor/Undo/ICreateDeleteDirectoryCommand.h
+++ b/src/Editor/Undo/ICreateDeleteDirectoryCommand.h
@@ -7,6 +7,8 @@
 #include <Core/GameProject/CResourceStore.h>
 #include <Core/GameProject/CVirtualDirectory.h>

+#include <QCoreApplication>
+
 class ICreateDeleteDirectoryCommand : public IUndoCommand
 {
 protected:
@@ -64,7 +66,7 @@ class CCreateDirectoryCommand : public ICreateDeleteDirectoryCommand
 {
 public:
    CCreateDirectoryCommand(CResourceStore *pStore, TString ParentPath, TString DirName)
-        : ICreateDeleteDirectoryCommand("Create Directory", pStore, ParentPath, DirName)
+        : ICreateDeleteDirectoryCommand(QCoreApplication::translate("CCreateDirectoryCommand", "Create Directory"), pStore, ParentPath, DirName)
    {}

    void undo() override { DoDelete(); }
@@ -75,7 +77,7 @@ class CDeleteDirectoryCommand : public ICreateDeleteDirectoryCommand
 {
 public:
    CDeleteDirectoryCommand(CResourceStore *pStore, TString ParentPath, TString DirName)
-        : ICreateDeleteDirectoryCommand("Delete Directory", pStore, ParentPath, DirName)
+        : ICreateDeleteDirectoryCommand(QCoreApplication::translate("CDeleteDirectoryCommand", "Delete Directory"), pStore, ParentPath, DirName)
    {
        mpDir = pStore->GetVirtualDirectory(ParentPath + DirName, false);
        ASSERT(mpDir);
--- a/src/Editor/Undo/ICreateDeleteResourceCommand.h
+++ b/src/Editor/Undo/ICreateDeleteResourceCommand.h
@@ -7,6 +7,8 @@
 #include <Core/GameProject/CResourceEntry.h>
 #include <Core/GameProject/CResourceStore.h>

+#include <QCoreApplication>
+
 class ICreateDeleteResourceCommand : public IUndoCommand
 {
 protected:
@@ -49,7 +51,7 @@ class CCreateResourceCommand : public ICreateDeleteResourceCommand
 {
 public:
    explicit CCreateResourceCommand(CResourceEntry* pEntry)
-        : ICreateDeleteResourceCommand("Create Resource", pEntry)
+        : ICreateDeleteResourceCommand(QCoreApplication::translate("CCreateResourceCommand", "Create Resource"), pEntry)
    {}

    void undo() override { DoDelete(); }
@@ -60,7 +62,7 @@ class CDeleteResourceCommand : public ICreateDeleteResourceCommand
 {
 public:
    explicit CDeleteResourceCommand(CResourceEntry* pEntry)
-        : ICreateDeleteResourceCommand("Delete Resource", pEntry)
+        : ICreateDeleteResourceCommand(QCoreApplication::translate("CDeleteResourceCommand", "Delete Resource"), pEntry)
    {}

    void undo() override { DoCreate(); }
--- a/src/Editor/Undo/IEditPropertyCommand.h
+++ b/src/Editor/Undo/IEditPropertyCommand.h
@@ -5,6 +5,8 @@
 #include "EUndoCommand.h"
 #include "Editor/PropertyEdit/CPropertyModel.h"

+#include <QCoreApplication>
+
 class IEditPropertyCommand : public IUndoCommand
 {
 protected:
@@ -30,7 +32,7 @@ public:
            IProperty* pProperty,
            CPropertyModel* pModel,
            const QModelIndex& kIndex,
-            const QString& kCommandName = "Edit Property"
+            const QString& kCommandName = QCoreApplication::translate("IEditPropertyCommand", "Edit Property")
            );

    ~IEditPropertyCommand() override = default;