AxioDL/PrimeWorldEditor
2
0
Fork 0
mirror of https://github.com/AxioDL/PrimeWorldEditor.git synced 2025-12-20 18:29:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

CLight: Return by reference where applicable

Browse Source 
Prevents unnecessary copies.
This commit is contained in:
Lioncache
2025-12-14 02:09:32 -05:00
parent 8e4e7f7742
commit 95f46dbc23
2 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/Core/Resource/CLight.h
View File

@@ -43,17 +43,17 @@ private:
public: public:
// Accessors // Accessors
ELightType Type() const { return mType; } ELightType Type() const { return mType; }
uint32 LayerIndex() const { return mLayerIndex; } uint32 LayerIndex() const { return mLayerIndex; }
CVector3f Position() const { return mPosition; } const CVector3f& Position() const { return mPosition; }
CVector3f Direction() const { return mDirection; } const CVector3f& Direction() const { return mDirection; }
CColor Color() const { return mColor; } const CColor& Color() const { return mColor; }
CVector3f DistAttenuation() const { return mDistAttenCoefficients; } const CVector3f& DistAttenuation() const { return mDistAttenCoefficients; }
CVector3f AngleAttenuation() const { return mAngleAttenCoefficients; } const CVector3f& AngleAttenuation() const { return mAngleAttenCoefficients; }
void SetLayer(uint32 Index) { mLayerIndex = Index; } void SetLayer(uint32 Index) { mLayerIndex = Index; }
void SetPosition(const CVector3f& rkPosition) { mPosition = rkPosition; } void SetPosition(const CVector3f& rkPosition) { mPosition = rkPosition; }
void SetDirection(const CVector3f& rkDirection) { mDirection = rkDirection; } void SetDirection(const CVector3f& rkDirection) { mDirection = rkDirection; }
float GetRadius() const; float GetRadius() const;
float GetIntensity() const; float GetIntensity() const;

10
src/Core/Scene/CSceneNode.cpp
View File

@@ -126,14 +126,14 @@ void CSceneNode::BuildLightList(CGameArea *pArea)
Index = 0; Index = 0;
struct SLightEntry { struct SLightEntry {
CLight *pLight; CLight* pLight;
float Distance; float Distance;
SLightEntry(CLight *_pLight, float _Distance) SLightEntry(CLight* pLight_, float Distance_)
: pLight(_pLight), Distance(_Distance) {} : pLight(pLight_), Distance(Distance_) {}
bool operator<(const SLightEntry& rkOther) const { bool operator<(const SLightEntry& rkOther) const {
return (Distance < rkOther.Distance); return Distance < rkOther.Distance;
} }
}; };
std::vector<SLightEntry> LightEntries; std::vector<SLightEntry> LightEntries;
@@ -159,7 +159,7 @@ void CSceneNode::BuildLightList(CGameArea *pArea)
if (IsInRange) if (IsInRange)
{ {
const float Dist = mPosition.Distance(pLight->Position()); const float Dist = mPosition.Distance(pLight->Position());
LightEntries.push_back(SLightEntry(pLight, Dist)); LightEntries.emplace_back(pLight, Dist);
} }
} }
} }