CRotateNodeCommand: Make use of override where applicable

This commit is contained in:
Lioncash 2020-06-28 05:37:47 -04:00
parent c118703ce5
commit fc2d48df87
2 changed files with 11 additions and 13 deletions

View File

@ -3,9 +3,7 @@
#include "Editor/INodeEditor.h" #include "Editor/INodeEditor.h"
CRotateNodeCommand::CRotateNodeCommand() CRotateNodeCommand::CRotateNodeCommand()
: IUndoCommand("Rotate"), : IUndoCommand("Rotate")
mpEditor(nullptr),
mCommandEnded(false)
{ {
} }
@ -19,8 +17,7 @@ CRotateNodeCommand::CRotateNodeCommand(
ETransformSpace TransformSpace ETransformSpace TransformSpace
) )
: IUndoCommand("Rotate"), : IUndoCommand("Rotate"),
mpEditor(pEditor), mpEditor(pEditor)
mCommandEnded(false)
{ {
mNodeList.reserve(rkNodes.size()); mNodeList.reserve(rkNodes.size());

View File

@ -18,18 +18,19 @@ class CRotateNodeCommand : public IUndoCommand
CQuaternion NewRot; CQuaternion NewRot;
}; };
QList<SNodeRotate> mNodeList; QList<SNodeRotate> mNodeList;
INodeEditor *mpEditor; INodeEditor *mpEditor = nullptr;
bool mCommandEnded; bool mCommandEnded = false;
public: public:
CRotateNodeCommand(); CRotateNodeCommand();
CRotateNodeCommand(INodeEditor *pEditor, const QList<CSceneNode*>& rkNodes, bool UsePivot, const CVector3f& rkPivot, const CQuaternion& rkPivotRotation, const CQuaternion& rkDelta, ETransformSpace TransformSpace); CRotateNodeCommand(INodeEditor *pEditor, const QList<CSceneNode*>& rkNodes, bool UsePivot, const CVector3f& rkPivot, const CQuaternion& rkPivotRotation, const CQuaternion& rkDelta, ETransformSpace TransformSpace);
~CRotateNodeCommand(); ~CRotateNodeCommand() override;
int id() const;
bool mergeWith(const QUndoCommand *pkOther); int id() const override;
void undo(); bool mergeWith(const QUndoCommand *pkOther) override;
void redo(); void undo() override;
bool AffectsCleanState() const { return true; } void redo() override;
bool AffectsCleanState() const override { return true; }
static CRotateNodeCommand* End(); static CRotateNodeCommand* End();
}; };