Commit Graph

15 Commits

Author SHA1 Message Date
Lioncache
deb1aaae01 CVirtualDirectoryModel: Mark Found variable as [[maybe_unused]]
This can technically be unused on release builds.
2025-12-07 02:26:08 -05:00
Lioncache
43eae548ac Editor: Convert QVector over to QList
In Qt 6 QVector is now a typedef alias for QList, so we can convert these over
to make the semantics explicit.
2025-11-30 15:44:23 -05:00
Lioncache
b2bd0cd326 General: Update to Qt6
Migrate over to Qt 6 so that we can keep the UI toolkit pegged at the
current major version.

Unfortunately this also means we have to gut a small feature in the
progress dialogs, since the extras module doesn't exist in Qt6 anymore.

Few things of note:

QVector<> is internally an alias of QList now, so any changeover is due
to that to make the semantics a little clearer.

QtConcurrent requires arguments to be swapped on some invocations, and
discarding instances need to use the global thread pool instead.

fromStdList(), etc can be replaced with range constructors.

--no-angle and other commands are removed from newer versions of
windeployqt

QVariant::Invalid (and other type IDs) are deprecated and also break
existing functionality. Instead we can return default constructed
QVariants where applicable, which restores functionality that would be
broken if left as is (e.g. many list would straight up not populate or
have wonky size hinting).

The reason for this is that the QVariant(QVariant::Type) constructor
models a unique kind of internal QVariant state where it's considered
to be in an invalid state, but accessing the (supposedly) invalid state
will instead return a default constructed value of the internal type.

This kinda sucks because this means genuinely invalid states that would
warrant an assertion or other type of error would be silently ignored
and execution would continue on as normal, so this also enforces
correctness a little bit (on top of, well, fixing all the broken UI
controls).
2025-11-29 19:54:35 -05:00
Lioncash
602c0cf1e3 CVirtualDirectoryModel: Mark GetIndexForDirectory as const
This function doesn't modify instance state.
2020-07-05 10:37:11 -04:00
Lioncash
05df1fcf89 CVirtualDirectory: Make use of size_t where applicable 2020-07-05 10:31:43 -04:00
Lioncash
97fa0c7f2d CVirtualDirectoryModel: Return std::optional from GetProposedIndex()
Same behavior, minus out parameters.
2020-07-05 10:19:52 -04:00
Lioncash
dcfb34ca1c CVirtualDirectoryModel: Eliminate string copies where applicable 2020-07-05 10:13:34 -04:00
Lioncash
d6309a54d3 CVirtualDirectoryModel: Make use of Qt 5 signals and slots 2020-06-29 05:11:07 -04:00
Lioncash
ec66d7af9d General: Make use of ranged for where applicable 2020-06-28 17:30:49 -04:00
Lioncash
041afedea3 CVirtualDirectoryModel: Mark strings as translatable where applicable 2020-06-28 06:15:37 -04:00
Lioncash
04bfb17f3c CVirtualDirectoryModel: Make use of in-class initializers where applicable 2020-06-28 06:14:50 -04:00
Jack Andersen
d593500e18 Codegen fixes, DPI scaling, SVG icons 2019-05-26 15:29:10 -10:00
Aruki
2287b05bc3 Refactor so PWE compiles with the newly externalized LibCommon 2018-12-11 22:50:46 -07:00
Aruki
18482cbae6 Added drag/drop support to directory tree view 2017-07-25 18:34:02 -06:00
Aruki
ca40c26154 Directory tree view now updates to reflect changes when moving/renaming folders 2017-07-25 04:02:48 -06:00