AxioDL
/
amuse
mirror of https://github.com/AxioDL/amuse.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix AppleClang -Wrange-loop-analysis warnings

This commit is contained in:
Luke Street 2021-03-05 09:26:26 -05:00
parent df7136d265
commit 217e791b88
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Editor/LayersEditor.cpp
View File

@ -519,7 +519,7 @@ void LayersTableView::deleteSelection() {
std::vector<std::pair<amuse::LayerMapping, int>> data; std::vector<std::pair<amuse::LayerMapping, int>> data;
data.reserve(list.size()); data.reserve(list.size());
for (const QModelIndex idx : list) { for (const QModelIndex& idx : list) {
data.emplace_back(amuse::LayerMapping{}, idx.row()); data.emplace_back(amuse::LayerMapping{}, idx.row());
} }

2
Editor/SongGroupEditor.cpp
View File

@ -1172,7 +1172,7 @@ void PageTableView::deleteSelection() {
std::vector<std::pair<uint8_t, amuse::SongGroupIndex::PageEntry>> data; std::vector<std::pair<uint8_t, amuse::SongGroupIndex::PageEntry>> data;
data.reserve(list.size()); data.reserve(list.size());
for (const QModelIndex idx : list) { for (const QModelIndex& idx : list) {
data.emplace_back(model()->data(idx).toInt() - 1, amuse::SongGroupIndex::PageEntry{}); data.emplace_back(model()->data(idx).toInt() - 1, amuse::SongGroupIndex::PageEntry{});
} }

2
Editor/SoundMacroEditor.cpp
View File

@ -243,7 +243,7 @@ CommandWidget::CommandWidget(QWidget* parent, amuse::SoundMacro::ICmd* cmd, amus
cb->setFixedHeight(30); cb->setFixedHeight(30);
cb->setProperty("fieldIndex", f); cb->setProperty("fieldIndex", f);
cb->setProperty("fieldName", fieldName); cb->setProperty("fieldName", fieldName);
for (const auto choice : field.m_choices) { for (const auto& choice : field.m_choices) {
if (choice.empty()) { if (choice.empty()) {
break; break;
} }