AxioDL
/
logvisor
mirror of https://github.com/AxioDL/logvisor.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

FileLogger: don't open/close file for each write

This commit is contained in:
Henrique Gemignani Passos Lima 2021-04-03 19:42:44 +03:00
parent 8913e55e34
commit d4af1a1088
1 changed files with 17 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
lib/logvisor.cpp
View File

@ -738,11 +738,21 @@ void RegisterStandardExceptions() {
} }
struct FileLogger : public ILogger { struct FileLogger : public ILogger {
FILE* fp; FILE* fp = nullptr;
FileLogger(uint64_t typeHash) : ILogger(typeHash) {} FileLogger(uint64_t typeHash) : ILogger(typeHash) {}
virtual void openFile() = 0; virtual void openFile() = 0;
virtual void closeFile() { std::fclose(fp); } void openFileIfNeeded() {
virtual ~FileLogger() = default; if (!fp) {
openFile();
}
}
virtual void closeFile() {
if (fp) {
std::fclose(fp);
fp = nullptr;
}
}
virtual ~FileLogger() { closeFile(); }
void _reportHead(const char* modName, const char* sourceInfo, Level severity) { void _reportHead(const char* modName, const char* sourceInfo, Level severity) {
const std::chrono::steady_clock::duration tm = CurrentUptime(); const std::chrono::steady_clock::duration tm = CurrentUptime();
@ -787,37 +797,33 @@ struct FileLogger : public ILogger {
} }
void report(const char* modName, Level severity, fmt::string_view format, fmt::format_args args) override { void report(const char* modName, Level severity, fmt::string_view format, fmt::format_args args) override {
openFile(); openFileIfNeeded();
_reportHead(modName, nullptr, severity); _reportHead(modName, nullptr, severity);
fmt::vprint(fp, format, args); fmt::vprint(fp, format, args);
std::fputc('\n', fp); std::fputc('\n', fp);
closeFile();
} }
void report(const char* modName, Level severity, fmt::wstring_view format, fmt::wformat_args args) override { void report(const char* modName, Level severity, fmt::wstring_view format, fmt::wformat_args args) override {
openFile(); openFileIfNeeded();
_reportHead(modName, nullptr, severity); _reportHead(modName, nullptr, severity);
fmt::vprint(fp, format, args); fmt::vprint(fp, format, args);
std::fputc('\n', fp); std::fputc('\n', fp);
closeFile();
} }
void reportSource(const char* modName, Level severity, const char* file, unsigned linenum, fmt::string_view format, void reportSource(const char* modName, Level severity, const char* file, unsigned linenum, fmt::string_view format,
fmt::format_args args) override { fmt::format_args args) override {
openFile(); openFileIfNeeded();
_reportHead(modName, fmt::format(FMT_STRING("{}:{}"), file, linenum).c_str(), severity); _reportHead(modName, fmt::format(FMT_STRING("{}:{}"), file, linenum).c_str(), severity);
fmt::vprint(fp, format, args); fmt::vprint(fp, format, args);
std::fputc('\n', fp); std::fputc('\n', fp);
closeFile();
} }
void reportSource(const char* modName, Level severity, const char* file, unsigned linenum, fmt::wstring_view format, void reportSource(const char* modName, Level severity, const char* file, unsigned linenum, fmt::wstring_view format,
fmt::wformat_args args) override { fmt::wformat_args args) override {
openFile(); openFileIfNeeded();
_reportHead(modName, fmt::format(FMT_STRING("{}:{}"), file, linenum).c_str(), severity); _reportHead(modName, fmt::format(FMT_STRING("{}:{}"), file, linenum).c_str(), severity);
fmt::vprint(fp, format, args); fmt::vprint(fp, format, args);
std::fputc('\n', fp); std::fputc('\n', fp);
closeFile();
} }
}; };