AxioDL/metaforce
2
0
Fork 0
mirror of https://github.com/AxioDL/metaforce.git synced 2025-12-08 23:07:42 +00:00
Code Issues Projects Releases Wiki Activity

General: Remove unnecessary std::move calls

Browse Source 
There's no real need to std::move a primitive type. A copy will be
performed either way. We can remove std::move in this case to improve
readability.
This commit is contained in:
Lioncash
2020-03-22 00:56:00 -04:00
parent 36ac0a8d78
commit 0e54861455
2 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
Runtime/Particle/CParticleDataFactory.cpp
View File

@@ -88,19 +88,20 @@ std::unique_ptr<CUVElement> CParticleDataFactory::GetTextureElement(CInputStream
return std::make_unique<CUVEConstant>(std::move(txtr));
}
case SBIG('ATEX'): {
FourCC subId = GetClassID(in);
if (subId == SBIG('NONE'))
const FourCC subId = GetClassID(in);
if (subId == SBIG('NONE')) {
return nullptr;
CAssetId id = in.readUint32Big();
}
const CAssetId id = in.readUint32Big();
auto a = GetIntElement(in);
auto b = GetIntElement(in);
auto c = GetIntElement(in);
auto d = GetIntElement(in);
auto e = GetIntElement(in);
bool f = GetBool(in);
const bool f = GetBool(in);
TToken<CTexture> txtr = resPool->GetObj({FOURCC('TXTR'), id});
return std::make_unique<CUVEAnimTexture>(std::move(txtr), std::move(std::move(a)), std::move(b), std::move(c),
std::move(d), std::move(e), std::move(f));
std::move(d), std::move(e), f);
}
default:
break;
@@ -174,17 +175,16 @@ std::unique_ptr<CModVectorElement> CParticleDataFactory::GetModVectorElement(CIn
auto b = GetRealElement(in);
auto c = GetRealElement(in);
auto d = GetRealElement(in);
bool e = GetBool(in);
return std::make_unique<CMVEImplosion>(std::move(a), std::move(b), std::move(c), std::move(d), std::move(e));
const bool e = GetBool(in);
return std::make_unique<CMVEImplosion>(std::move(a), std::move(b), std::move(c), std::move(d), e);
}
case SBIG('EMPL'): {
auto a = GetVectorElement(in);
auto b = GetRealElement(in);
auto c = GetRealElement(in);
auto d = GetRealElement(in);
bool e = GetBool(in);
return std::make_unique<CMVEExponentialImplosion>(std::move(a), std::move(b), std::move(c), std::move(d),
std::move(e));
const bool e = GetBool(in);
return std::make_unique<CMVEExponentialImplosion>(std::move(a), std::move(b), std::move(c), std::move(d), e);
}
case SBIG('CHAN'): {
auto a = GetModVectorElement(in);
@@ -197,8 +197,8 @@ std::unique_ptr<CModVectorElement> CParticleDataFactory::GetModVectorElement(CIn
auto b = GetVectorElement(in);
auto c = GetRealElement(in);
auto d = GetRealElement(in);
bool e = GetBool(in);
return std::make_unique<CMVEBounce>(std::move(a), std::move(b), std::move(c), std::move(d), std::move(e));
const bool e = GetBool(in);
return std::make_unique<CMVEBounce>(std::move(a), std::move(b), std::move(c), std::move(d), e);
}
case SBIG('CNST'): {
auto a = GetRealElement(in);
@@ -232,8 +232,8 @@ std::unique_ptr<CModVectorElement> CParticleDataFactory::GetModVectorElement(CIn
auto b = GetRealElement(in);
auto c = GetRealElement(in);
auto d = GetRealElement(in);
bool e = GetBool(in);
return std::make_unique<CMVELinearImplosion>(std::move(a), std::move(b), std::move(c), std::move(d), std::move(e));
const bool e = GetBool(in);
return std::make_unique<CMVELinearImplosion>(std::move(a), std::move(b), std::move(c), std::move(d), e);
}
case SBIG('PULS'): {
auto a = GetIntElement(in);
@@ -424,8 +424,8 @@ std::unique_ptr<CRealElement> CParticleDataFactory::GetRealElement(CInputStream&
return std::make_unique<CRELifetimeTween>(std::move(a), std::move(b));
}
case SBIG('CNST'): {
float a = GetReal(in);
return std::make_unique<CREConstant>(std::move(a));
const float a = GetReal(in);
return std::make_unique<CREConstant>(a);
}
case SBIG('CHAN'): {
auto a = GetRealElement(in);
@@ -628,8 +628,8 @@ std::unique_ptr<CIntElement> CParticleDataFactory::GetIntElement(CInputStream& i
return std::make_unique<CIEAdd>(std::move(a), std::move(b));
}
case SBIG('CNST'): {
int a = GetInt(in);
return std::make_unique<CIEConstant>(std::move(a));
const int a = GetInt(in);
return std::make_unique<CIEConstant>(a);
}
case SBIG('IMPL'): {
auto a = GetIntElement(in);