AxioDL
/
metaforce
mirror of https://github.com/AxioDL/metaforce.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

CLogBookScreen: Dehardcode constants where applicable 

We can just query the containers for the iteration value
This commit is contained in:
Lioncash 2019-10-15 09:12:58 -04:00
parent 4b78d51a85
commit 3951a07bfa
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Runtime/MP1/CLogBookScreen.cpp
View File

@ -34,7 +34,7 @@ bool CLogBookScreen::IsScanComplete(CSaveWorld::EScanCategory category, CAssetId
} }
void CLogBookScreen::InitializeLogBook() { void CLogBookScreen::InitializeLogBook() {
for (int i = 0; i < 5; ++i) { for (size_t i = 0; i < x19c_scanCompletes.size(); ++i) {
x19c_scanCompletes[i].reserve(g_MemoryCardSys->GetScanCategoryCount(CSaveWorld::EScanCategory(i + 1))); x19c_scanCompletes[i].reserve(g_MemoryCardSys->GetScanCategoryCount(CSaveWorld::EScanCategory(i + 1)));
} }
@ -345,7 +345,7 @@ void CLogBookScreen::Draw(float transInterp, float totalAlpha, float yOff) {
bool CLogBookScreen::VReady() const { return true; } bool CLogBookScreen::VReady() const { return true; }
void CLogBookScreen::VActivate() { void CLogBookScreen::VActivate() {
for (int i = 0; i < 5; ++i) { for (int i = 0; i < int(xa8_textpane_categories.size()); ++i) {
if (IsScanCategoryReady(CSaveWorld::EScanCategory(i + 1))) { if (IsScanCategoryReady(CSaveWorld::EScanCategory(i + 1))) {
xa8_textpane_categories[i]->TextSupport().SetText(xc_pauseStrg.GetString(i + 1)); xa8_textpane_categories[i]->TextSupport().SetText(xc_pauseStrg.GetString(i + 1));
} else { } else {