AxioDL/metaforce
2
0
Fork 0
mirror of https://github.com/AxioDL/metaforce.git synced 2025-12-18 03:25:24 +00:00
Code Issues Projects Releases Wiki Activity

Runtime: Add more usages of explicit

Browse Source 
Prevents error-prone implicit conversions where applicable.

This targets the regular RuntimeCommon target this time around.
This commit is contained in:
Lioncash
2020-03-30 23:52:22 -04:00
parent 3e4731bf7f
commit 67f6666ea1
110 changed files with 326 additions and 315 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Runtime/Character/CFBStreamedAnimReader.hpp
View File

@@ -42,7 +42,7 @@ class CFBStreamedAnimReaderTotals {
void Allocate(u32 chanCount);
public:
CFBStreamedAnimReaderTotals(const CFBStreamedCompression& source);
explicit CFBStreamedAnimReaderTotals(const CFBStreamedCompression& source);
void Initialize(const CFBStreamedCompression& source);
void IncrementInto(CBitLevelLoader& loader, const CFBStreamedCompression& source, CFBStreamedAnimReaderTotals& dest);
void CalculateDown();
@@ -61,7 +61,7 @@ class CFBStreamedPairOfTotals {
float x78_t = 0.f;
public:
CFBStreamedPairOfTotals(const TSubAnimTypeToken<CFBStreamedCompression>& source);
explicit CFBStreamedPairOfTotals(const TSubAnimTypeToken<CFBStreamedCompression>& source);
void SetTime(CBitLevelLoader& loader, const CCharAnimTime& time);
void DoIncrement(CBitLevelLoader& loader);
float GetT() const { return x78_t; }
@@ -76,7 +76,7 @@ class CBitLevelLoader {
size_t m_bitIdx = 0;
public:
CBitLevelLoader(const void* data) : m_data(reinterpret_cast<const u8*>(data)) {}
explicit CBitLevelLoader(const void* data) : m_data(reinterpret_cast<const u8*>(data)) {}
void Reset() { m_bitIdx = 0; }
u32 LoadUnsigned(u8 q);
s32 LoadSigned(u8 q);
@@ -88,7 +88,7 @@ class CSegIdToIndexConverter {
std::array<s32,100> x0_indices;
public:
CSegIdToIndexConverter(const CFBStreamedAnimReaderTotals& totals);
explicit CSegIdToIndexConverter(const CFBStreamedAnimReaderTotals& totals);
s32 SegIdToIndex(const CSegId& id) const { return x0_indices[id]; }
};
@@ -104,7 +104,7 @@ class CFBStreamedAnimReader : public CAnimSourceReaderBase {
zeus::CQuaternion GetRotation(const CSegId& seg) const;
public:
CFBStreamedAnimReader(const TSubAnimTypeToken<CFBStreamedCompression>& source, const CCharAnimTime& time);
explicit CFBStreamedAnimReader(const TSubAnimTypeToken<CFBStreamedCompression>& source, const CCharAnimTime& time);
SAdvancementResults VGetAdvancementResults(const CCharAnimTime& a, const CCharAnimTime& b) const override;
bool VSupportsReverseView() const override { return false; }