AxioDL/metaforce
2
0
Fork 0
mirror of https://github.com/AxioDL/metaforce.git synced 2025-07-03 12:35:51 +00:00
Code Issues Projects Releases Wiki Activity

SpecMP3: Prevent unnecessary copies

Browse Source 
Prevents iterating over elements by value and also uses auto to ensure
the iterated item matches 1:1.
This commit is contained in:
Lioncash 2020-03-31 12:28:40 -04:00
parent 315becf1b5
commit 94c4c0f102
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
DataSpec/SpecMP3.cpp
View File

@ -132,7 +132,7 @@ struct SpecMP3 : SpecBase {
} }
/* Assemble extract report */ /* Assemble extract report */
for (const std::pair<std::string, DNAMP3::PAKBridge*>& item : fe ? m_feOrderedPaks : m_orderedPaks) { for (const auto& item : fe ? m_feOrderedPaks : m_orderedPaks) {
if (!item.second->m_doExtract) if (!item.second->m_doExtract)
continue; continue;
rep.childOpts.emplace_back(); rep.childOpts.emplace_back();
@ -394,7 +394,7 @@ struct SpecMP3 : SpecBase {
progress.startNewLine(); progress.startNewLine();
hecl::ClientProcess process; hecl::ClientProcess process;
for (std::pair<std::string, DNAMP3::PAKBridge*> pair : m_feOrderedPaks) { for (auto& pair : m_feOrderedPaks) {
DNAMP3::PAKBridge& pak = *pair.second; DNAMP3::PAKBridge& pak = *pair.second;
if (!pak.m_doExtract) if (!pak.m_doExtract)
continue; continue;