AxioDL
/
metaforce
mirror of https://github.com/AxioDL/metaforce.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

CHudDecoInterface: Make virtual calls in constructor explicitly qualified 

Virtual functions called in a constructor or destructor are statically
resolved. Given this is a potential source of bugs, we qualify these
functions to make it explicit that this is indeed the kind of behavior
desired.
This commit is contained in:
Lioncash 2020-04-13 14:52:31 -04:00
parent 3a5a3e2011
commit c8be142846
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Runtime/GuiSys/CHudDecoInterface.cpp
View File

@ -34,7 +34,7 @@ CHudDecoInterfaceCombat::CHudDecoInterfaceCombat(CGuiFrame& selHud) {
x78_basewidget_tickdeco0->SetColor(g_tweakGuiColors->GetTickDecoColor()); x78_basewidget_tickdeco0->SetColor(g_tweakGuiColors->GetTickDecoColor());
x38_basePosition = x7c_basewidget_frame->GetLocalPosition(); x38_basePosition = x7c_basewidget_frame->GetLocalPosition();
x44_baseRotation = x7c_basewidget_frame->GetLocalTransform().buildMatrix3f(); x44_baseRotation = x7c_basewidget_frame->GetLocalTransform().buildMatrix3f();
UpdateHudAlpha(); CHudDecoInterfaceCombat::UpdateHudAlpha();
} }
void CHudDecoInterfaceCombat::UpdateVisibility() { void CHudDecoInterfaceCombat::UpdateVisibility() {
@ -127,7 +127,7 @@ CHudDecoInterfaceScan::CHudDecoInterfaceScan(CGuiFrame& selHud) : x14_selHud(sel
x250_basewidget_rightside->SetLocalPosition(x250_basewidget_rightside->RotateO2P(x224_rightsidePosition - sidesPos)); x250_basewidget_rightside->SetLocalPosition(x250_basewidget_rightside->RotateO2P(x224_rightsidePosition - sidesPos));
x234_sidesPositioner = FLT_MAX; x234_sidesPositioner = FLT_MAX;
UpdateHudAlpha(); CHudDecoInterfaceScan::UpdateHudAlpha();
} }
void CHudDecoInterfaceScan::UpdateVisibility() { void CHudDecoInterfaceScan::UpdateVisibility() {
@ -377,7 +377,7 @@ CHudDecoInterfaceXRay::CHudDecoInterfaceXRay(CGuiFrame& selHud) {
if (CGuiWidget* w = selHud.FindWidget("model_threatslider")) if (CGuiWidget* w = selHud.FindWidget("model_threatslider"))
w->SetDepthWrite(true); w->SetDepthWrite(true);
UpdateHudAlpha(); CHudDecoInterfaceXRay::UpdateHudAlpha();
} }
void CHudDecoInterfaceXRay::UpdateVisibility() { void CHudDecoInterfaceXRay::UpdateVisibility() {