AxioDL/metaforce
2
0
Fork 0
mirror of https://github.com/AxioDL/metaforce.git synced 2025-12-10 16:27:43 +00:00
Code Issues Projects Releases Wiki Activity

General: Use emplace_back's return value where applicable

Browse Source 
emplace_back() returns a reference to the added element, so we can use
that instead of querying right after the emplacement.
This commit is contained in:
Lioncash
2019-09-05 19:36:40 -04:00
parent 8ff9e028c7
commit fa56ba5db6
4 changed files with 20 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
specter/lib/Menu.cpp
View File

@@ -55,9 +55,7 @@ void Menu::reset(IMenuNode* rootNode) {
for (size_t i = 0; i < subCount; ++i) {
IMenuNode* node = rootNode->subNode(i);
const std::string* nodeText = node->text();
m_items.emplace_back();
ViewChild<std::unique_ptr<ItemView>>& item = m_items.back();
ViewChild<std::unique_ptr<ItemView>>& item = m_items.emplace_back();
if (nodeText) {
item.m_view.reset(new ItemView(res, *this, *nodeText, i, node));