Merge pull request #563 from Dmitry-Me/betterParameterNameInClone

Better parameter name
This commit is contained in:
Lee Thomason 2017-06-19 14:23:39 -07:00 committed by GitHub
commit 9201bb96d3
2 changed files with 6 additions and 6 deletions

View File

@ -772,13 +772,13 @@ void XMLNode::SetValue( const char* str, bool staticMem )
} }
} }
XMLNode* XMLNode::DeepClone(XMLDocument* document) const XMLNode* XMLNode::DeepClone(XMLDocument* target) const
{ {
XMLNode* clone = this->ShallowClone(document); XMLNode* clone = this->ShallowClone(target);
if (!clone) return 0; if (!clone) return 0;
for (const XMLNode* child = this->FirstChild(); child; child = child->NextSibling()) { for (const XMLNode* child = this->FirstChild(); child; child = child->NextSibling()) {
XMLNode* childClone = child->DeepClone(document); XMLNode* childClone = child->DeepClone(target);
TIXMLASSERT(childClone); TIXMLASSERT(childClone);
clone->InsertEndChild(childClone); clone->InsertEndChild(childClone);
} }

View File

@ -868,8 +868,8 @@ public:
/** /**
Make a copy of this node and all its children. Make a copy of this node and all its children.
If the 'document' is null, then the nodes will If the 'target' is null, then the nodes will
be allocated in the current document. If document be allocated in the current document. If 'target'
is specified, the memory will be allocated is the is specified, the memory will be allocated is the
specified XMLDocument. specified XMLDocument.
@ -878,7 +878,7 @@ public:
top level XMLNodes. You probably want to use top level XMLNodes. You probably want to use
XMLDocument::DeepCopy() XMLDocument::DeepCopy()
*/ */
XMLNode* DeepClone( XMLDocument* document ) const; XMLNode* DeepClone( XMLDocument* target ) const;
/** /**
Test if 2 nodes are the same, but don't test children. Test if 2 nodes are the same, but don't test children.